Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Issue 2426523002: Audit use of updateStyleAndLayoutIgnorePendingStylesheets in EditingStyle::styleAtSelectionStart (Closed)

Created:
4 years, 2 months ago by Xiaocheng
Modified:
4 years, 2 months ago
Reviewers:
tkent, yosin_UTC9
CC:
blink-reviews, blink-reviews-style_chromium.org, chromium-reviews, kinuko+watch
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Audit use of updateStyleAndLayoutIgnorePendingStylesheets in EditingStyle::styleAtSelectionStart BUG=590369 Committed: https://crrev.com/def6e18a32707f8d84e22cc2d736fdc6b31f8903 Cr-Commit-Position: refs/heads/master@{#425858}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
M third_party/WebKit/Source/core/editing/EditingStyle.cpp View 1 chunk +1 line, -4 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp View 2 chunks +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/ContextMenuClientImpl.cpp View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
Xiaocheng
PTAL.
4 years, 2 months ago (2016-10-17 09:03:41 UTC) #4
yosin_UTC9
lgtm
4 years, 2 months ago (2016-10-17 09:47:05 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2426523002/1
4 years, 2 months ago (2016-10-17 09:47:19 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/282441)
4 years, 2 months ago (2016-10-17 09:56:19 UTC) #11
tkent
lgtm
4 years, 2 months ago (2016-10-18 01:54:57 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2426523002/1
4 years, 2 months ago (2016-10-18 02:13:14 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-18 02:17:56 UTC) #15
commit-bot: I haz the power
4 years, 2 months ago (2016-10-18 02:20:08 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/def6e18a32707f8d84e22cc2d736fdc6b31f8903
Cr-Commit-Position: refs/heads/master@{#425858}

Powered by Google App Engine
This is Rietveld 408576698