Audit use of updateStyleAndLayoutIgnorePendingStylesheets in EditingStyle::styleAtSelectionStart

third_party/WebKit/Source/core/editing/EditingStyle.cpp

 /*
  * Copyright (C) 2007, 2008, 2009 Apple Computer, Inc.
  * Copyright (C) 2010, 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 1510 matching lines @@
 
 EditingStyle* EditingStyle::styleAtSelectionStart(
     const VisibleSelection& selection,
     bool shouldUseBackgroundColorInEffect,
     MutableStylePropertySet* styleToCheck) {
   if (selection.isNone())
     return nullptr;
 
   Document& document = *selection.start().document();
 
-  // TODO(xiaochengh): The use of updateStyleAndLayoutIgnorePendingStylesheets
-  // needs to be audited. see http://crbug.com/590369 for more details.
-  document.updateStyleAndLayoutIgnorePendingStylesheets();
-
+  DCHECK(!document.needsLayoutTreeUpdate());
   DocumentLifecycle::DisallowTransitionScope disallowTransition(
       document.lifecycle());
 
   Position position = adjustedSelectionStartForStyleComputation(selection);
 
   // If the pos is at the end of a text node, then this node is not fully
   // selected. Move it to the next deep equivalent position to avoid removing
   // the style from this node.
   // e.g. if pos was at Position("hello", 5) in <b>hello<div>world</div></b>, we
   // want Position("world", 0) instead.
@@ skipping 495 matching lines @@
   for (Node* ancestor = node; ancestor; ancestor = ancestor->parentNode()) {
     CSSComputedStyleDeclaration* ancestorStyle =
         CSSComputedStyleDeclaration::create(ancestor);
     if (!hasTransparentBackgroundColor(ancestorStyle))
       return ancestorStyle->getPropertyCSSValue(CSSPropertyBackgroundColor);
   }
   return nullptr;
 }
 
 }  // namespace blink