Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 2426513002: Prune createVisiblePositionDeprecated (Closed)

Created:
4 years, 2 months ago by Xiaocheng
Modified:
4 years, 2 months ago
Reviewers:
tkent, yosin_UTC9
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Prune createVisiblePositionDeprecated This patch updates layout for the remaining callers of createVisiblePositionDeprecated, so that now all VisiblePositions are created in clean layout. createVisiblePositionDeprecated no longer has any call site, and hence, is removed. BUG=647219 Committed: https://crrev.com/be2e6e1eb24a7f7a5be000c8b7afda118cb85b4b Cr-Commit-Position: refs/heads/master@{#425654}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -65 lines) Patch
M third_party/WebKit/Source/core/dom/Range.cpp View 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/FrameCaret.cpp View 1 chunk +11 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/editing/VisiblePosition.h View 1 chunk +0 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/core/editing/VisiblePosition.cpp View 1 chunk +0 lines, -46 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
Xiaocheng
PTAL. This patch closes crbug.com/647219
4 years, 2 months ago (2016-10-17 08:12:23 UTC) #4
yosin_UTC9
lgtm
4 years, 2 months ago (2016-10-17 08:19:30 UTC) #5
yosin_UTC9
+tkent@ for core/dom/Range.cpp
4 years, 2 months ago (2016-10-17 08:19:54 UTC) #7
tkent
lgtm
4 years, 2 months ago (2016-10-17 08:36:08 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2426513002/1
4 years, 2 months ago (2016-10-17 11:09:19 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-17 11:14:30 UTC) #13
commit-bot: I haz the power
4 years, 2 months ago (2016-10-17 11:16:14 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/be2e6e1eb24a7f7a5be000c8b7afda118cb85b4b
Cr-Commit-Position: refs/heads/master@{#425654}

Powered by Google App Engine
This is Rietveld 408576698