Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: third_party/WebKit/Source/core/editing/VisiblePosition.h

Issue 2426513002: Prune createVisiblePositionDeprecated (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2004, 2008 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 120 matching lines...) Expand 10 before | Expand all | Expand 10 after
131 131
132 extern template class CORE_EXTERN_TEMPLATE_EXPORT 132 extern template class CORE_EXTERN_TEMPLATE_EXPORT
133 VisiblePositionTemplate<EditingStrategy>; 133 VisiblePositionTemplate<EditingStrategy>;
134 extern template class CORE_EXTERN_TEMPLATE_EXPORT 134 extern template class CORE_EXTERN_TEMPLATE_EXPORT
135 VisiblePositionTemplate<EditingInFlatTreeStrategy>; 135 VisiblePositionTemplate<EditingInFlatTreeStrategy>;
136 136
137 using VisiblePosition = VisiblePositionTemplate<EditingStrategy>; 137 using VisiblePosition = VisiblePositionTemplate<EditingStrategy>;
138 using VisiblePositionInFlatTree = 138 using VisiblePositionInFlatTree =
139 VisiblePositionTemplate<EditingInFlatTreeStrategy>; 139 VisiblePositionTemplate<EditingInFlatTreeStrategy>;
140 140
141 // |createVisiblePositionDeprecated| updates layout before creating the
142 // VisiblePosition, which messes up the rendering pipeline. The callers should
143 // ensure clean layout by themselves and call |createVisiblePosition| instead.
144 CORE_EXPORT VisiblePosition
145 createVisiblePositionDeprecated(const Position&,
146 TextAffinity = VP_DEFAULT_AFFINITY);
147 CORE_EXPORT VisiblePosition
148 createVisiblePositionDeprecated(const PositionWithAffinity&);
149 CORE_EXPORT VisiblePositionInFlatTree
150 createVisiblePositionDeprecated(const PositionInFlatTree&,
151 TextAffinity = VP_DEFAULT_AFFINITY);
152 CORE_EXPORT VisiblePositionInFlatTree
153 createVisiblePositionDeprecated(const PositionInFlatTreeWithAffinity&);
154
155 CORE_EXPORT VisiblePosition 141 CORE_EXPORT VisiblePosition
156 createVisiblePosition(const Position&, TextAffinity = VP_DEFAULT_AFFINITY); 142 createVisiblePosition(const Position&, TextAffinity = VP_DEFAULT_AFFINITY);
157 CORE_EXPORT VisiblePosition createVisiblePosition(const PositionWithAffinity&); 143 CORE_EXPORT VisiblePosition createVisiblePosition(const PositionWithAffinity&);
158 CORE_EXPORT VisiblePositionInFlatTree 144 CORE_EXPORT VisiblePositionInFlatTree
159 createVisiblePosition(const PositionInFlatTree&, 145 createVisiblePosition(const PositionInFlatTree&,
160 TextAffinity = VP_DEFAULT_AFFINITY); 146 TextAffinity = VP_DEFAULT_AFFINITY);
161 CORE_EXPORT VisiblePositionInFlatTree 147 CORE_EXPORT VisiblePositionInFlatTree
162 createVisiblePosition(const PositionInFlatTreeWithAffinity&); 148 createVisiblePosition(const PositionInFlatTreeWithAffinity&);
163 149
164 CORE_EXPORT std::ostream& operator<<(std::ostream&, const VisiblePosition&); 150 CORE_EXPORT std::ostream& operator<<(std::ostream&, const VisiblePosition&);
165 CORE_EXPORT std::ostream& operator<<(std::ostream&, 151 CORE_EXPORT std::ostream& operator<<(std::ostream&,
166 const VisiblePositionInFlatTree&); 152 const VisiblePositionInFlatTree&);
167 153
168 } // namespace blink 154 } // namespace blink
169 155
170 #ifndef NDEBUG 156 #ifndef NDEBUG
171 // Outside the WebCore namespace for ease of invocation from gdb. 157 // Outside the WebCore namespace for ease of invocation from gdb.
172 void showTree(const blink::VisiblePosition*); 158 void showTree(const blink::VisiblePosition*);
173 void showTree(const blink::VisiblePosition&); 159 void showTree(const blink::VisiblePosition&);
174 #endif 160 #endif
175 161
176 #endif // VisiblePosition_h 162 #endif // VisiblePosition_h
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/editing/FrameCaret.cpp ('k') | third_party/WebKit/Source/core/editing/VisiblePosition.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698