Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1042)

Unified Diff: content/browser/frame_host/render_frame_host_impl.h

Issue 2426503002: Make printing work better with OOPIF. (Closed)
Patch Set: Fix build, fix some tests Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/render_frame_host_impl.h
diff --git a/content/browser/frame_host/render_frame_host_impl.h b/content/browser/frame_host/render_frame_host_impl.h
index 90059a0138474c552fd87133bd087ef0cb6f74d6..09f9b567f8a352a0ce38653d04804d21c9dbfc86 100644
--- a/content/browser/frame_host/render_frame_host_impl.h
+++ b/content/browser/frame_host/render_frame_host_impl.h
@@ -68,6 +68,10 @@ class WebBluetoothService;
}
}
+namespace gfx {
+class Range;
+}
+
namespace content {
class AppWebMessagePortMessageFilter;
class AssociatedInterfaceProviderImpl;
@@ -161,6 +165,7 @@ class CONTENT_EXPORT RenderFrameHostImpl
int GetProxyCount() override;
void FilesSelectedInChooser(const std::vector<FileChooserFileInfo>& files,
FileChooserParams::Mode permissions) override;
+ bool HasSelection() override;
void RequestTextSurroundingSelection(
const TextSurroundingSelectionCallback& callback,
int max_length) override;
@@ -278,7 +283,7 @@ class CONTENT_EXPORT RenderFrameHostImpl
// distinguished by owning a RenderWidgetHost, which manages input events
// and painting for this frame and its contiguous local subtree in the
// renderer process.
- bool is_local_root() { return !!render_widget_host_; }
+ bool is_local_root() const { return !!render_widget_host_; }
// Returns the RenderWidgetHostImpl attached to this frame or the nearest
// ancestor frame, which could potentially be the root. For most input
@@ -719,6 +724,9 @@ class CONTENT_EXPORT RenderFrameHostImpl
bool success,
const std::set<std::string>& digests_of_uris_of_serialized_resources,
base::TimeDelta renderer_main_thread_time);
+ void OnSelectionChanged(const base::string16& text,
+ uint32_t offset,
+ const gfx::Range& range);
#if defined(USE_EXTERNAL_POPUP_MENU)
void OnShowPopup(const FrameHostMsg_ShowPopup_Params& params);
@@ -801,10 +809,9 @@ class CONTENT_EXPORT RenderFrameHostImpl
// Sends a navigate message to the RenderFrame and notifies DevTools about
// navigation happening. Should be used instead of sending the message
// directly.
- void SendNavigateMessage(
- const content::CommonNavigationParams& common_params,
- const content::StartNavigationParams& start_params,
- const content::RequestNavigationParams& request_params);
+ void SendNavigateMessage(const CommonNavigationParams& common_params,
+ const StartNavigationParams& start_params,
+ const RequestNavigationParams& request_params);
// Returns the child FrameTreeNode if |child_frame_routing_id| is an
// immediate child of this FrameTreeNode. |child_frame_routing_id| is
@@ -1041,6 +1048,8 @@ class CONTENT_EXPORT RenderFrameHostImpl
// called (no pending instance should be set).
bool should_reuse_web_ui_;
+ bool has_selection_;
+
// PlzNavigate: The LoFi state of the last navigation. This is used during
// history navigation of subframes to ensure that subframes navigate with the
// same LoFi status as the top-level frame.

Powered by Google App Engine
This is Rietveld 408576698