Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(542)

Unified Diff: components/printing/common/print_messages.h

Issue 2426503002: Make printing work better with OOPIF. (Closed)
Patch Set: Fix build, fix some tests Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/printing/common/print_messages.h
diff --git a/components/printing/common/print_messages.h b/components/printing/common/print_messages.h
index a0191448ccf9f0654177ec5efb8603723bb1b022..c7bdb045923255b4ba35e21806f18032ac92f2e9 100644
--- a/components/printing/common/print_messages.h
+++ b/components/printing/common/print_messages.h
@@ -312,8 +312,8 @@ IPC_STRUCT_END()
// Messages sent from the browser to the renderer.
#if defined(ENABLE_PRINT_PREVIEW)
-// Tells the render view to initiate print preview for the entire document.
-IPC_MESSAGE_ROUTED1(PrintMsg_InitiatePrintPreview, bool /* selection_only */)
+// Tells the render frame to initiate print preview for the entire document.
nasko 2016/10/27 20:26:26 nit: s/render frame/RenderFrame/
Lei Zhang 2016/10/28 23:27:10 Done.
+IPC_MESSAGE_ROUTED1(PrintMsg_InitiatePrintPreview, bool /* has_selection */)
#endif // defined(ENABLE_PRINT_PREVIEW)
// Tells the render frame to initiate printing or print preview for a particular
@@ -329,7 +329,7 @@ IPC_MESSAGE_ROUTED1(PrintMsg_PrintForPrintPreview,
#endif // defined(ENABLE_BASIC_PRINTING) && defined(ENABLE_PRINT_PREVIEW)
#if defined(ENABLE_BASIC_PRINTING)
-// Tells the render view to switch the CSS to print media type, renders every
+// Tells the render frame to switch the CSS to print media type, renders every
// requested pages and switch back the CSS to display media type.
IPC_MESSAGE_ROUTED0(PrintMsg_PrintPages)
@@ -337,16 +337,15 @@ IPC_MESSAGE_ROUTED0(PrintMsg_PrintPages)
IPC_MESSAGE_ROUTED0(PrintMsg_PrintForSystemDialog)
#endif // defined(ENABLE_BASIC_PRINTING)
-// Tells the render view that printing is done so it can clean up.
+// Tells the render frame that printing is done so it can clean up.
IPC_MESSAGE_ROUTED1(PrintMsg_PrintingDone,
bool /* success */)
-// Tells the render view whether scripted printing is blocked or not.
-IPC_MESSAGE_ROUTED1(PrintMsg_SetScriptedPrintingBlocked,
- bool /* blocked */)
+// Tells the render frame whether printing is enabled or not.
+IPC_MESSAGE_ROUTED1(PrintMsg_SetPrintingEnabled, bool /* enabled */)
#if defined(ENABLE_PRINT_PREVIEW)
-// Tells the render view to switch the CSS to print media type, renders every
+// Tells the render frame to switch the CSS to print media type, renders every
// requested pages for print preview using the given |settings|. This gets
// called multiple times as the user updates settings.
IPC_MESSAGE_ROUTED1(PrintMsg_PrintPreview,
@@ -355,10 +354,6 @@ IPC_MESSAGE_ROUTED1(PrintMsg_PrintPreview,
// Messages sent from the renderer to the browser.
-// Check if printing is enabled.
-IPC_SYNC_MESSAGE_ROUTED0_1(PrintHostMsg_IsPrintingEnabled,
- bool /* is_enabled */)
-
// Tells the browser that the renderer is done calculating the number of
// rendered pages according to the specified settings.
IPC_MESSAGE_ROUTED2(PrintHostMsg_DidGetPrintedPagesCount,

Powered by Google App Engine
This is Rietveld 408576698