ui/android/delegated_frame_host_android.cc - Issue 2425923003: Replaced is_null() with is_valid in SurfaceId and related classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/android/delegated_frame_host_android.cc

Issue 2425923003: Replaced is_null() with is_valid in SurfaceId and related classes. (Closed)

Patch Set: Removed added printf statements; LocalFrameId::is_valid() no longer checks if nonce is 0. Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/android/delegated_frame_host_android.cc

diff --git a/ui/android/delegated_frame_host_android.cc b/ui/android/delegated_frame_host_android.cc

index 7b26124a754f11d4e1c73a84141e04bc62f8b2b8..7c06b2f4f099963aa8f5cac1448708bf6f216aa1 100644

--- a/ui/android/delegated_frame_host_android.cc

+++ b/ui/android/delegated_frame_host_android.cc

@@ -226,7 +226,7 @@ void DelegatedFrameHostAndroid::UpdateContainerSizeinDIP(

void DelegatedFrameHostAndroid::RegisterFrameSinkHierarchy(

const cc::FrameSinkId& parent_id) {

- if (!registered_parent_frame_sink_id_.is_null())

+ if (registered_parent_frame_sink_id_.is_valid())

UnregisterFrameSinkHierarchy();

registered_parent_frame_sink_id_ = parent_id;

surface_manager_->RegisterSurfaceFactoryClient(frame_sink_id_, this);

@@ -234,7 +234,7 @@ void DelegatedFrameHostAndroid::RegisterFrameSinkHierarchy(

}

void DelegatedFrameHostAndroid::UnregisterFrameSinkHierarchy() {

- if (registered_parent_frame_sink_id_.is_null())

+ if (!registered_parent_frame_sink_id_.is_valid())

return;

surface_manager_->UnregisterSurfaceFactoryClient(frame_sink_id_);

surface_manager_->UnregisterFrameSinkHierarchy(