Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Side by Side Diff: ui/android/delegated_frame_host_android.cc

Issue 2425923003: Replaced is_null() with is_valid in SurfaceId and related classes. (Closed)
Patch Set: Removed added printf statements; LocalFrameId::is_valid() no longer checks if nonce is 0. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ui/android/delegated_frame_host_android.h" 5 #include "ui/android/delegated_frame_host_android.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/logging.h" 8 #include "base/logging.h"
9 #include "cc/layers/solid_color_layer.h" 9 #include "cc/layers/solid_color_layer.h"
10 #include "cc/layers/surface_layer.h" 10 #include "cc/layers/surface_layer.h"
(...skipping 208 matching lines...) Expand 10 before | Expand all | Expand 10 after
219 void DelegatedFrameHostAndroid::UpdateContainerSizeinDIP( 219 void DelegatedFrameHostAndroid::UpdateContainerSizeinDIP(
220 const gfx::Size& size_in_dip) { 220 const gfx::Size& size_in_dip) {
221 container_size_in_dip_ = size_in_dip; 221 container_size_in_dip_ = size_in_dip;
222 background_layer_->SetBounds(gfx::ConvertSizeToPixel( 222 background_layer_->SetBounds(gfx::ConvertSizeToPixel(
223 gfx::DeviceDisplayInfo().GetDIPScale(), container_size_in_dip_)); 223 gfx::DeviceDisplayInfo().GetDIPScale(), container_size_in_dip_));
224 UpdateBackgroundLayer(); 224 UpdateBackgroundLayer();
225 } 225 }
226 226
227 void DelegatedFrameHostAndroid::RegisterFrameSinkHierarchy( 227 void DelegatedFrameHostAndroid::RegisterFrameSinkHierarchy(
228 const cc::FrameSinkId& parent_id) { 228 const cc::FrameSinkId& parent_id) {
229 if (!registered_parent_frame_sink_id_.is_null()) 229 if (registered_parent_frame_sink_id_.is_valid())
230 UnregisterFrameSinkHierarchy(); 230 UnregisterFrameSinkHierarchy();
231 registered_parent_frame_sink_id_ = parent_id; 231 registered_parent_frame_sink_id_ = parent_id;
232 surface_manager_->RegisterSurfaceFactoryClient(frame_sink_id_, this); 232 surface_manager_->RegisterSurfaceFactoryClient(frame_sink_id_, this);
233 surface_manager_->RegisterFrameSinkHierarchy(parent_id, frame_sink_id_); 233 surface_manager_->RegisterFrameSinkHierarchy(parent_id, frame_sink_id_);
234 } 234 }
235 235
236 void DelegatedFrameHostAndroid::UnregisterFrameSinkHierarchy() { 236 void DelegatedFrameHostAndroid::UnregisterFrameSinkHierarchy() {
237 if (registered_parent_frame_sink_id_.is_null()) 237 if (!registered_parent_frame_sink_id_.is_valid())
238 return; 238 return;
239 surface_manager_->UnregisterSurfaceFactoryClient(frame_sink_id_); 239 surface_manager_->UnregisterSurfaceFactoryClient(frame_sink_id_);
240 surface_manager_->UnregisterFrameSinkHierarchy( 240 surface_manager_->UnregisterFrameSinkHierarchy(
241 registered_parent_frame_sink_id_, frame_sink_id_); 241 registered_parent_frame_sink_id_, frame_sink_id_);
242 registered_parent_frame_sink_id_ = cc::FrameSinkId(); 242 registered_parent_frame_sink_id_ = cc::FrameSinkId();
243 } 243 }
244 244
245 void DelegatedFrameHostAndroid::ReturnResources( 245 void DelegatedFrameHostAndroid::ReturnResources(
246 const cc::ReturnedResourceArray& resources) { 246 const cc::ReturnedResourceArray& resources) {
247 return_resources_callback_.Run(resources); 247 return_resources_callback_.Run(resources);
(...skipping 20 matching lines...) Expand all
268 content_size_in_dip.width() < container_size_in_dip_.width() || 268 content_size_in_dip.width() < container_size_in_dip_.width() ||
269 content_size_in_dip.height() < container_size_in_dip_.height(); 269 content_size_in_dip.height() < container_size_in_dip_.height();
270 } else { 270 } else {
271 background_is_drawable = true; 271 background_is_drawable = true;
272 } 272 }
273 273
274 background_layer_->SetIsDrawable(background_is_drawable); 274 background_layer_->SetIsDrawable(background_is_drawable);
275 } 275 }
276 276
277 } // namespace ui 277 } // namespace ui
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698