services/ui/ws/server_window_surface.h - Issue 2425923003: Replaced is_null() with is_valid in SurfaceId and related classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: services/ui/ws/server_window_surface.h

Issue 2425923003: Replaced is_null() with is_valid in SurfaceId and related classes. (Closed)

Patch Set: Removed added printf statements; LocalFrameId::is_valid() no longer checks if nonce is 0. Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: services/ui/ws/server_window_surface.h

diff --git a/services/ui/ws/server_window_surface.h b/services/ui/ws/server_window_surface.h

index 1a606c250652357e3b24fba444f34ffc77a389f3..c1d89e838551a7c94e73cac0dbfe31d468073028 100644

--- a/services/ui/ws/server_window_surface.h

+++ b/services/ui/ws/server_window_surface.h

@@ -63,7 +63,7 @@ class ServerWindowSurface : public mojom::Surface,

// the same size and device scale factor.

const cc::LocalFrameId& local_frame_id() const { return local_frame_id_; }

- bool has_frame() const { return !local_frame_id_.is_null(); }

+ bool has_frame() const { return local_frame_id_.is_valid(); }

cc::SurfaceId GetSurfaceId() const;