services/ui/surfaces/compositor_frame_sink.cc - Issue 2425923003: Replaced is_null() with is_valid in SurfaceId and related classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: services/ui/surfaces/compositor_frame_sink.cc

Issue 2425923003: Replaced is_null() with is_valid in SurfaceId and related classes. (Closed)

Patch Set: Removed added printf statements; LocalFrameId::is_valid() no longer checks if nonce is 0. Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: services/ui/surfaces/compositor_frame_sink.cc

diff --git a/services/ui/surfaces/compositor_frame_sink.cc b/services/ui/surfaces/compositor_frame_sink.cc

index c880bd130d122447cedd8eeb369424f72e49433f..02945fe7e02e2c365f5af081581891f6a9eb55c3 100644

--- a/services/ui/surfaces/compositor_frame_sink.cc

+++ b/services/ui/surfaces/compositor_frame_sink.cc

@@ -93,7 +93,7 @@ void CompositorFrameSink::SubmitCompositorFrame(

gfx::Size frame_size =

frame.delegated_frame_data->render_pass_list.back()->output_rect.size();

if (frame_size.IsEmpty() || frame_size != display_size_) {

- if (!local_frame_id_.is_null())

+ if (local_frame_id_.is_valid())

factory_.Destroy(local_frame_id_);

local_frame_id_ = allocator_.GenerateId();

factory_.Create(local_frame_id_);