Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 2425903003: Disable WebUSB detector logic on Windows. (Closed)

Created:
4 years, 2 months ago by Reilly Grant (use Gerrit)
Modified:
4 years, 2 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

Disable WebUSB detector logic on Windows. Initializing the WebUSB device detector logic causes the USB subsystem to attempt to fully enumerate the system's USB bus. This has been found to cause jank and hangs on Chrome's FILE thread on Windows. Disabling this component of WebUSB while the issue is investigated. WebUSB will continue to function but this change will prevent the issue from impacting users who do not visit sites using it. BUG=656702 TEST=Verified USB subsystem is not initialized on startup on Windows by checking chrome://device-log. Verified still initialized on Linux. Review-Url: https://codereview.chromium.org/2422403003 Cr-Commit-Position: refs/heads/master@{#425867} (cherry picked from commit dfd32df76aea1a2d4f1aad69c74ded742a2ac69b) Committed: https://chromium.googlesource.com/chromium/src/+/2ac51a5dd890c0944f4d689792319426fb5f9850

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M chrome/browser/usb/web_usb_detector.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/usb/web_usb_detector_unittest.cc View 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Reilly Grant (use Gerrit)
4 years, 2 months ago (2016-10-18 22:21:22 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2ac51a5dd890c0944f4d689792319426fb5f9850.

Powered by Google App Engine
This is Rietveld 408576698