Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 2425483002: Remove usage of FOR_EACH_OBSERVER macro in remoting (Closed)

Created:
4 years, 2 months ago by Eric Willigers
Modified:
4 years, 2 months ago
Reviewers:
Sergey Ulanov, garykac
CC:
chromium-reviews, chromoting-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove usage of FOR_EACH_OBSERVER macro in remoting Observer lists now support range-based for loops. BUG=655021 Committed: https://crrev.com/1c729e8d010011dde4608d7c177ab227ac9d203b Cr-Commit-Position: refs/heads/master@{#425796}

Patch Set 1 #

Total comments: 2

Patch Set 2 : braces #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -56 lines) Patch
M remoting/host/chromoting_host.cc View 1 5 chunks +16 lines, -15 lines 0 comments Download
M remoting/host/daemon_process.cc View 2 chunks +14 lines, -11 lines 0 comments Download
M remoting/protocol/webrtc_audio_source_adapter.cc View 1 chunk +8 lines, -6 lines 0 comments Download
M remoting/signaling/delegating_signal_strategy.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/signaling/fake_signal_strategy.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M remoting/signaling/xmpp_signal_strategy.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M remoting/test/test_chromoting_client.cc View 4 chunks +12 lines, -12 lines 0 comments Download

Messages

Total messages: 19 (13 generated)
Eric Willigers
4 years, 2 months ago (2016-10-15 13:08:10 UTC) #6
Sergey Ulanov
LGTM when my comment is addressed https://codereview.chromium.org/2425483002/diff/1/remoting/host/chromoting_host.cc File remoting/host/chromoting_host.cc (right): https://codereview.chromium.org/2425483002/diff/1/remoting/host/chromoting_host.cc#newcode97 remoting/host/chromoting_host.cc:97: if (started_) Please ...
4 years, 2 months ago (2016-10-17 16:45:31 UTC) #8
Eric Willigers
https://codereview.chromium.org/2425483002/diff/1/remoting/host/chromoting_host.cc File remoting/host/chromoting_host.cc (right): https://codereview.chromium.org/2425483002/diff/1/remoting/host/chromoting_host.cc#newcode97 remoting/host/chromoting_host.cc:97: if (started_) On 2016/10/17 16:45:31, Sergey Ulanov wrote: > ...
4 years, 2 months ago (2016-10-17 22:32:31 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2425483002/20001
4 years, 2 months ago (2016-10-17 22:33:24 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-17 22:40:28 UTC) #17
commit-bot: I haz the power
4 years, 2 months ago (2016-10-17 22:43:12 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1c729e8d010011dde4608d7c177ab227ac9d203b
Cr-Commit-Position: refs/heads/master@{#425796}

Powered by Google App Engine
This is Rietveld 408576698