Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1085)

Unified Diff: remoting/signaling/xmpp_signal_strategy.cc

Issue 2425483002: Remove usage of FOR_EACH_OBSERVER macro in remoting (Closed)
Patch Set: braces Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/signaling/fake_signal_strategy.cc ('k') | remoting/test/test_chromoting_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/signaling/xmpp_signal_strategy.cc
diff --git a/remoting/signaling/xmpp_signal_strategy.cc b/remoting/signaling/xmpp_signal_strategy.cc
index 591dac2c4b907bd5cd7236d8ead0c90f6abbddc1..8a019e432dd560ed153b4acacfbceea15a1f1a84 100644
--- a/remoting/signaling/xmpp_signal_strategy.cc
+++ b/remoting/signaling/xmpp_signal_strategy.cc
@@ -174,8 +174,8 @@ void XmppSignalStrategy::Core::Connect() {
error_ = OK;
- FOR_EACH_OBSERVER(Listener, listeners_,
- OnSignalStrategyStateChange(CONNECTING));
+ for (auto& observer : listeners_)
+ observer.OnSignalStrategyStateChange(CONNECTING);
socket_.reset(new jingle_glue::ProxyResolvingClientSocket(
socket_factory_, request_context_getter_, net::SSLConfig(),
@@ -203,8 +203,8 @@ void XmppSignalStrategy::Core::Disconnect() {
tls_state_ = TlsState::NOT_REQUESTED;
read_pending_ = false;
- FOR_EACH_OBSERVER(Listener, listeners_,
- OnSignalStrategyStateChange(DISCONNECTED));
+ for (auto& observer : listeners_)
+ observer.OnSignalStrategyStateChange(DISCONNECTED);
}
}
@@ -336,8 +336,8 @@ void XmppSignalStrategy::Core::OnHandshakeDone(
// Don't need |login_handler_| anymore.
login_handler_.reset();
- FOR_EACH_OBSERVER(Listener, listeners_,
- OnSignalStrategyStateChange(CONNECTED));
+ for (auto& observer : listeners_)
+ observer.OnSignalStrategyStateChange(CONNECTED);
}
void XmppSignalStrategy::Core::OnLoginHandlerError(
« no previous file with comments | « remoting/signaling/fake_signal_strategy.cc ('k') | remoting/test/test_chromoting_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698