android_webview/native/aw_contents_io_thread_client_impl.h - Issue 2425423004: Move NewDownload out of AwContentsIoThreadClientImpl to AwContentsClientBridge

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/native/aw_contents_io_thread_client_impl.h

Issue 2425423004: Move NewDownload out of AwContentsIoThreadClientImpl to AwContentsClientBridge (Closed)

Patch Set: changed "even if" to "unless" Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: android_webview/native/aw_contents_io_thread_client_impl.h

diff --git a/android_webview/native/aw_contents_io_thread_client_impl.h b/android_webview/native/aw_contents_io_thread_client_impl.h

index b1c640c8f1c86b419c1396d1703deeb7d9feafa2..a8683c26698f799b83c49494d12ac32dc5a69d88 100644

--- a/android_webview/native/aw_contents_io_thread_client_impl.h

+++ b/android_webview/native/aw_contents_io_thread_client_impl.h

@@ -60,11 +60,6 @@ class AwContentsIoThreadClientImpl : public AwContentsIoThreadClient {

bool ShouldBlockFileUrls() const override;

bool ShouldAcceptThirdPartyCookies() const override;

bool ShouldBlockNetworkLoads() const override;

- void NewDownload(const GURL& url,

- const std::string& user_agent,

- const std::string& content_disposition,

- const std::string& mime_type,

- int64_t content_length) override;

void NewLoginRequest(const std::string& realm,

const std::string& account,

const std::string& args) override;