Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(708)

Unified Diff: android_webview/native/aw_contents_io_thread_client_impl.cc

Issue 2425423004: Move NewDownload out of AwContentsIoThreadClientImpl to AwContentsClientBridge (Closed)
Patch Set: changed "even if" to "unless" Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/native/aw_contents_io_thread_client_impl.cc
diff --git a/android_webview/native/aw_contents_io_thread_client_impl.cc b/android_webview/native/aw_contents_io_thread_client_impl.cc
index 4080b9b5317a08cd611bde5579e9e220d559e123..7e8d6f1b07d3016da514df04ed316f831624616f 100644
--- a/android_webview/native/aw_contents_io_thread_client_impl.cc
+++ b/android_webview/native/aw_contents_io_thread_client_impl.cc
@@ -402,31 +402,6 @@ bool AwContentsIoThreadClientImpl::ShouldBlockNetworkLoads() const {
java_object_);
}
-void AwContentsIoThreadClientImpl::NewDownload(
- const GURL& url,
- const string& user_agent,
- const string& content_disposition,
- const string& mime_type,
- int64_t content_length) {
- DCHECK_CURRENTLY_ON(BrowserThread::IO);
- if (java_object_.is_null())
- return;
-
- JNIEnv* env = AttachCurrentThread();
- ScopedJavaLocalRef<jstring> jstring_url =
- ConvertUTF8ToJavaString(env, url.spec());
- ScopedJavaLocalRef<jstring> jstring_user_agent =
- ConvertUTF8ToJavaString(env, user_agent);
- ScopedJavaLocalRef<jstring> jstring_content_disposition =
- ConvertUTF8ToJavaString(env, content_disposition);
- ScopedJavaLocalRef<jstring> jstring_mime_type =
- ConvertUTF8ToJavaString(env, mime_type);
-
- Java_AwContentsIoThreadClient_onDownloadStart(
- env, java_object_, jstring_url, jstring_user_agent,
- jstring_content_disposition, jstring_mime_type, content_length);
-}
-
void AwContentsIoThreadClientImpl::NewLoginRequest(const string& realm,
const string& account,
const string& args) {

Powered by Google App Engine
This is Rietveld 408576698