Issue 2425243002: CM API: disallow a federated credential to update a password credential.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2425243002: CM API: disallow a federated credential to update a password credential. (Closed)

Created:
4 years, 2 months ago by vasilii

Modified:
4 years, 2 months ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/2883

Project:
chromium

Visibility:
Public.

CM API: disallow a federated credential to update a password credential. BUG=653364 Review-Url: https://codereview.chromium.org/2416783002 Cr-Commit-Position: refs/heads/master@{#425017} (cherry picked from commit f0afbfdae3929aa90e5ef611f02cd2f81e6ebdff) Committed: https://chromium.googlesource.com/chromium/src/+/4e78201c38098209d4a2c9b559cbdc0704e625b2

Created: 4 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+38 lines, -0 lines)			Patch
	M	components/password_manager/content/browser/credential_manager_impl_unittest.cc	View		2 chunks	+36 lines, -0 lines	0 comments	Download
	M	components/password_manager/core/browser/password_form_manager.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Total messages: 2 (1 generated)

vasilii

4 years, 2 months ago (2016-10-18 13:12:28 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
4e78201c38098209d4a2c9b559cbdc0704e625b2.