CM API: disallow a federated credential to update a password credential.

CM API: disallow a federated credential to update a password credential.

BUG=653364
Committed: https://crrev.com/f0afbfdae3929aa90e5ef611f02cd2f81e6ebdff
Cr-Commit-Position: refs/heads/master@{#425017}

[vasilii, 2016-10-13 03:00:31]

The CQ bit was checked by vasilii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-13 03:00:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[vasilii, 2016-10-13 03:01:10]

vasilii@chromium.org changed reviewers:
+ vabr@chromium.org

[vasilii, 2016-10-13 03:01:10]

Hi Vaclav,

please review.

[commit-bot: I haz the power, 2016-10-13 03:52:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-13 03:52:24]

Dry run: This issue passed the CQ dry run.

[vabr (Chromium), 2016-10-13 07:59:43]

LGTM, the fix makes sense, and the test is very clear.
Cheers,
Vaclav

https://codereview.chromium.org/2416783002/diff/1/components/password_manager...
File
components/password_manager/content/browser/credential_manager_impl_unittest.cc
(right):

https://codereview.chromium.org/2416783002/diff/1/components/password_manager...
components/password_manager/content/browser/credential_manager_impl_unittest.cc:472:
// Allow the PasswordFormManager to talk to the password store, determine
Just wanted to say that this is a very well written and helpful comment!

[vasilii, 2016-10-13 13:59:37]

https://codereview.chromium.org/2416783002/diff/1/components/password_manager...
File
components/password_manager/content/browser/credential_manager_impl_unittest.cc
(right):

https://codereview.chromium.org/2416783002/diff/1/components/password_manager...
components/password_manager/content/browser/credential_manager_impl_unittest.cc:472:
// Allow the PasswordFormManager to talk to the password store, determine
On 2016/10/13 07:59:43, vabr (Chromium) wrote:
> Just wanted to say that this is a very well written and helpful comment!

written by Mike, I just copy pasted. Kudos to me that I didn't delete it ;-)

[vasilii, 2016-10-13 13:59:43]

The CQ bit was checked by vasilii@chromium.org

[commit-bot: I haz the power, 2016-10-13 14:00:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[vabr (Chromium), 2016-10-13 14:04:26]

https://codereview.chromium.org/2416783002/diff/1/components/password_manager...
File
components/password_manager/content/browser/credential_manager_impl_unittest.cc
(right):

https://codereview.chromium.org/2416783002/diff/1/components/password_manager...
components/password_manager/content/browser/credential_manager_impl_unittest.cc:472:
// Allow the PasswordFormManager to talk to the password store, determine
On 2016/10/13 13:59:37, vasilii wrote:
> On 2016/10/13 07:59:43, vabr (Chromium) wrote:
> > Just wanted to say that this is a very well written and helpful comment!
> 
> written by Mike, I just copy pasted. Kudos to me that I didn't delete it ;-)

:D

[commit-bot: I haz the power, 2016-10-13 14:05:24]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-13 14:06:57]

Description was changed from

==========
CM API: disallow a federated credential to update a password credential.

BUG=653364
==========

to

==========
CM API: disallow a federated credential to update a password credential.

BUG=653364

Committed: https://crrev.com/f0afbfdae3929aa90e5ef611f02cd2f81e6ebdff
Cr-Commit-Position: refs/heads/master@{#425017}
==========

[commit-bot: I haz the power, 2016-10-13 14:06:58]

Patchset 1 (id:??) landed as
https://crrev.com/f0afbfdae3929aa90e5ef611f02cd2f81e6ebdff
Cr-Commit-Position: refs/heads/master@{#425017}