Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(793)

Issue 24251011: Revert 224269 "Don't persist HPKP if PrivacyMode is enabled." (Closed)

Created:
7 years, 3 months ago by tkent
Modified:
7 years, 3 months ago
Reviewers:
mef, mef1
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 224269 "Don't persist HPKP if PrivacyMode is enabled." It broke Google Chrome ChromeOS bot. http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20ChromeOS/builds/58548/steps/compile/logs/stdio#error1 FAILED: g++ ... -c ../../net/socket/ssl_client_socket_nss.cc -o obj/net/socket/net.ssl_client_socket_nss.o ../../net/socket/ssl_client_socket_nss.cc: In member function 'int net::SSLClientSocketNSS::DoVerifyCertComplete(int)': ../../net/socket/ssl_client_socket_nss.cc:3445:64:error: no matching function for call to 'net::TransportSecurityState::GetDomainState(const string&, bool&, net::TransportSecurityState::DomainState*)' ../../net/socket/ssl_client_socket_nss.cc:3445:64: note: candidate is: ../../net/http/transport_security_state.h:212:8: note: bool net::TransportSecurityState::GetDomainState(const string&, bool, bool, net::TransportSecurityState::DomainState*) ../../net/http/transport_security_state.h:212:8: note: candidate expects 4 arguments, 3 provided > Don't persist HPKP if PrivacyMode is enabled. > > BUG=258667 > > Review URL: https://chromiumcodereview.appspot.com/19269012 TBR=mef@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=224275

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -197 lines) Patch
M trunk/src/chrome/browser/net/transport_security_persister_unittest.cc View 4 chunks +8 lines, -10 lines 0 comments Download
M trunk/src/chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc View 1 chunk +10 lines, -1 line 0 comments Download
M trunk/src/chrome/browser/ui/webui/net_internals/net_internals_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome_frame/test/net/fake_external_tab.cc View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/net/http/http_security_headers_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/net/http/transport_security_state.h View 2 chunks +0 lines, -4 lines 0 comments Download
M trunk/src/net/http/transport_security_state.cc View 3 chunks +2 lines, -8 lines 0 comments Download
M trunk/src/net/http/transport_security_state_unittest.cc View 16 chunks +47 lines, -60 lines 0 comments Download
M trunk/src/net/socket_stream/socket_stream.h View 2 chunks +0 lines, -7 lines 0 comments Download
M trunk/src/net/socket_stream/socket_stream.cc View 2 chunks +2 lines, -13 lines 0 comments Download
M trunk/src/net/socket_stream/socket_stream_job.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M trunk/src/net/url_request/url_request.cc View 1 chunk +6 lines, -11 lines 0 comments Download
M trunk/src/net/url_request/url_request_http_job.cc View 3 chunks +1 line, -21 lines 0 comments Download
M trunk/src/net/url_request/url_request_test_util.h View 1 chunk +2 lines, -1 line 0 comments Download
trunk/src/net/url_request/url_request_unittest.cc View 9 chunks +12 lines, -46 lines 0 comments Download
M trunk/src/net/websockets/websocket_job.h View 1 chunk +2 lines, -0 lines 0 comments Download
M trunk/src/net/websockets/websocket_job.cc View 4 chunks +12 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
tkent
7 years, 3 months ago (2013-09-20 03:53:36 UTC) #1
tkent
Committed patchset #1 manually as r224275.
7 years, 3 months ago (2013-09-20 03:54:07 UTC) #2
mef1
7 years, 3 months ago (2013-09-20 15:27:05 UTC) #3
Thanks for the revert!
My try builds didn't fail because the broken code is inside of
#ifdefined(OFFICIAL_BUILD).


On Thu, Sep 19, 2013 at 11:54 PM, <tkent@chromium.org> wrote:

> Committed patchset #1 manually as r224275.
>
>
https://codereview.chromium.**org/24251011/<https://codereview.chromium.org/2...
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698