Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Unified Diff: trunk/src/net/url_request/url_request_http_job.cc

Issue 24251011: Revert 224269 "Don't persist HPKP if PrivacyMode is enabled." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « trunk/src/net/url_request/url_request.cc ('k') | trunk/src/net/url_request/url_request_test_util.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/net/url_request/url_request_http_job.cc
===================================================================
--- trunk/src/net/url_request/url_request_http_job.cc (revision 224274)
+++ trunk/src/net/url_request/url_request_http_job.cc (working copy)
@@ -795,13 +795,6 @@
!security_state)
return;
- CookieOptions options;
- options.set_include_httponly();
- options.set_server_time(response_date_);
- // Don't persist HSTS if cookies are not saved to avoid tracking.
- if ((request_info_.load_flags & LOAD_DO_NOT_SAVE_COOKIES) ||
- !CanSetCookie("", &options))
- return;
// http://tools.ietf.org/html/draft-ietf-websec-strict-transport-sec:
//
// If a UA receives more than one STS header field in a HTTP response
@@ -825,14 +818,6 @@
!security_state)
return;
- CookieOptions options;
- options.set_include_httponly();
- options.set_server_time(response_date_);
- // Don't persist HPKP if cookies are not saved to avoid tracking.
- if ((request_info_.load_flags & LOAD_DO_NOT_SAVE_COOKIES) ||
- !CanSetCookie("", &options))
- return;
-
// http://tools.ietf.org/html/draft-ietf-websec-key-pinning:
//
// If a UA receives more than one PKP header field in an HTTP
@@ -909,16 +894,11 @@
// what we should do.
TransportSecurityState::DomainState domain_state;
- bool allow_dynamic_state =
- !(request_info_.load_flags & LOAD_DO_NOT_SEND_COOKIES) &&
- CanGetCookies(CookieList());
const URLRequestContext* context = request_->context();
- const bool fatal =
- context->transport_security_state() &&
+ const bool fatal = context->transport_security_state() &&
context->transport_security_state()->GetDomainState(
request_info_.url.host(),
SSLConfigService::IsSNIAvailable(context->ssl_config_service()),
- allow_dynamic_state,
&domain_state) &&
domain_state.ShouldSSLErrorsBeFatal();
NotifySSLCertificateError(transaction_->GetResponseInfo()->ssl_info, fatal);
« no previous file with comments | « trunk/src/net/url_request/url_request.cc ('k') | trunk/src/net/url_request/url_request_test_util.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698