Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 2424843002: [Telemetry] Remove the logic of killing stray adb processes (Closed)

Created:
4 years, 2 months ago by nednguyen
Modified:
4 years, 1 month ago
Reviewers:
jbudorick, eyaich1
CC:
catapult-reviews_chromium.org, telemetry-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

[Telemetry] Remove the logic of killing stray adb processes This was a hack to provide a bandaid fix for crbug.com/656224. BUG=chromium:656224 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/0adb6ef9b5dd024442c143933dd58d946f0f9bac

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -17 lines) Patch
M telemetry/telemetry/internal/platform/android_device.py View 3 chunks +1 line, -17 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
nednguyen
4 years, 2 months ago (2016-10-17 15:16:37 UTC) #3
jbudorick
Sorry about the delay. lgtm
4 years, 1 month ago (2016-11-07 01:18:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2424843002/1
4 years, 1 month ago (2016-11-07 13:48:57 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/0adb6ef9b5dd024442c143933dd58d946f0f9bac
4 years, 1 month ago (2016-11-07 14:08:48 UTC) #8
aiolos (Not reviewing)
4 years, 1 month ago (2016-11-07 21:42:21 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2487493002/ by aiolos@chromium.org.

The reason for reverting is: Looks like this is causing errors when landing in
chrome.
From https://codereview.chromium.org/2477243003


A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2484833002/ by scheib@chromium.org.

The reason for reverting is: Failed compile on official.desktop.continuous for
win trunk
https://bugs.chromium.org/p/chromium/issues/detail?id=662998

Link to Build:
-------------
https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/w...

Link to Log Path:
------------------
https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/w...

Error log :

FAILED: net_unittests.exe net_unittests.exe.pdb 
C:/b/depot_tools/python276_bin/python.exe
../../build/toolchain/win/tool_wrapper.py link-wrapper environment.x64 False
link.exe /nologo /OUT:./net_unittests.exe /PDB:./net_unittests.exe.pdb
@./net_unittests.exe.rsp
c:\b\build\slave\win_trunk\build\src\v8\src\heap\mark-compact.cc(1278) : fatal
error C1001: An internal error has occurred in the compiler.
(compiler file 'f:\dd\vctools\compiler\utc\src\p2\main.c', line 255)
 To work around this problem, try simplifying or changing the program near the
locations listed above.
Please choose the Technical Support command on the Visual C++ 
 Help menu, or open the Technical Support help file for more information


scheib@ could you please look into this. thank you .

Powered by Google App Engine
This is Rietveld 408576698