Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 2477243003: Roll src/third_party/catapult/ 8ac279fd8..0adb6ef9b (1 commit). (Closed)

Created:
4 years, 1 month ago by catapult-deps-roller
Modified:
4 years, 1 month ago
Reviewers:
catapult-sheriff
CC:
chromium-reviews, catapult-sheriff_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll src/third_party/catapult/ 8ac279fd8..0adb6ef9b (1 commit). https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/8ac279fd8db3..0adb6ef9b5dd $ git log 8ac279fd8..0adb6ef9b --date=short --no-merges --format='%ad %ae %s' 2016-11-07 nednguyen [Telemetry] Remove the logic of killing stray adb processes BUG=656224 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=catapult-sheriff@chromium.org Committed: https://crrev.com/4711d631a805e410531fbba09e9c69278b2d17c0 Cr-Commit-Position: refs/heads/master@{#430279}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
catapult-deps-roller
4 years, 1 month ago (2016-11-07 14:51:23 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2477243003/1
4 years, 1 month ago (2016-11-07 14:51:42 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-07 16:01:29 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/4711d631a805e410531fbba09e9c69278b2d17c0 Cr-Commit-Position: refs/heads/master@{#430279}
4 years, 1 month ago (2016-11-07 16:03:39 UTC) #6
scheib
4 years, 1 month ago (2016-11-07 18:42:14 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2484833002/ by scheib@chromium.org.

The reason for reverting is: Failed compile on official.desktop.continuous for
win trunk
https://bugs.chromium.org/p/chromium/issues/detail?id=662998

Link to Build:
-------------
https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/w...

Link to Log Path:
------------------
https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/w...

Error log :

FAILED: net_unittests.exe net_unittests.exe.pdb 
C:/b/depot_tools/python276_bin/python.exe
../../build/toolchain/win/tool_wrapper.py link-wrapper environment.x64 False
link.exe /nologo /OUT:./net_unittests.exe /PDB:./net_unittests.exe.pdb
@./net_unittests.exe.rsp
c:\b\build\slave\win_trunk\build\src\v8\src\heap\mark-compact.cc(1278) : fatal
error C1001: An internal error has occurred in the compiler.
(compiler file 'f:\dd\vctools\compiler\utc\src\p2\main.c', line 255)
 To work around this problem, try simplifying or changing the program near the
locations listed above.
Please choose the Technical Support command on the Visual C++ 
 Help menu, or open the Technical Support help file for more information


scheib@ could you please look into this. thank you 
 
.

Powered by Google App Engine
This is Rietveld 408576698