Revert of Replace for loops with |arraysize| with for each loops

Revert of Replace for loops with |arraysize| with for each loops (patchset #2 id:20001 of https://codereview.chromium.org/2417783004/ )

Reason for revert:
Speculative revert from sheriff. Suspect that the CL breaks components_unittests on Mac.

https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.9%20Tests%20%28dbg%29/builds/31721/steps/components_unittests%20on%20Mac-10.9

Not sure. Will revert the revert if it does not help.

Original issue's description:
> Replace for loops with |arraysize| with for each loops
>
> This change replaces for-loops involving a loop variable and the
> |arraysize| macro with a C++11 for-each-loop where appropriate.
>
> A few usages of |arraysize| in a for-loop remain, in these the loop
> variable is used as well. This can be simply logging the iteration
> number or indexing another array of the same size.
>
> BUG=655950
>
> Committed: https://crrev.com/54e466c9fd2ff04136f8f305615910e8f9085642
> Cr-Commit-Position: refs/heads/master@{#425651}

TBR=vabr@chromium.org,jdoerrie@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=655950
Committed: https://crrev.com/e00a337f9c62d1d32c315ecacc63cec380a36e27
Cr-Commit-Position: refs/heads/master@{#425660}

[henrika (OOO until Aug 14), 2016-10-17 12:15:08]

The CQ bit was checked by henrika@chromium.org

[henrika (OOO until Aug 14), 2016-10-17 12:15:09]

Created Revert of Replace for loops with |arraysize| with for each loops

[commit-bot: I haz the power, 2016-10-17 12:15:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-17 12:16:31]

Description was changed from

==========
Revert of Replace for loops with |arraysize| with for each loops (patchset #2
id:20001 of https://codereview.chromium.org/2417783004/ )

Reason for revert:
Speculative revert from sheriff. Suspect that the CL breaks components_unittests
on Mac.

https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.9%20Tests%...

Not sure. Will revert the revert if it does not help.

Original issue's description:
> Replace for loops with |arraysize| with for each loops
> 
> This change replaces for-loops involving a loop variable and the
> |arraysize| macro with a C++11 for-each-loop where appropriate.
> 
> A few usages of |arraysize| in a for-loop remain, in these the loop
> variable is used as well. This can be simply logging the iteration
> number or indexing another array of the same size.
> 
> BUG=655950
> 
> Committed: https://crrev.com/54e466c9fd2ff04136f8f305615910e8f9085642
> Cr-Commit-Position: refs/heads/master@{#425651}

TBR=vabr@chromium.org,jdoerrie@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=655950
==========

to

==========
Revert of Replace for loops with |arraysize| with for each loops (patchset #2
id:20001 of https://codereview.chromium.org/2417783004/ )

Reason for revert:
Speculative revert from sheriff. Suspect that the CL breaks components_unittests
on Mac.

https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.9%20Tests%...

Not sure. Will revert the revert if it does not help.

Original issue's description:
> Replace for loops with |arraysize| with for each loops
> 
> This change replaces for-loops involving a loop variable and the
> |arraysize| macro with a C++11 for-each-loop where appropriate.
> 
> A few usages of |arraysize| in a for-loop remain, in these the loop
> variable is used as well. This can be simply logging the iteration
> number or indexing another array of the same size.
> 
> BUG=655950
> 
> Committed: https://crrev.com/54e466c9fd2ff04136f8f305615910e8f9085642
> Cr-Commit-Position: refs/heads/master@{#425651}

TBR=vabr@chromium.org,jdoerrie@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=655950
==========

[commit-bot: I haz the power, 2016-10-17 12:16:32]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-17 12:19:11]

Description was changed from

==========
Revert of Replace for loops with |arraysize| with for each loops (patchset #2
id:20001 of https://codereview.chromium.org/2417783004/ )

Reason for revert:
Speculative revert from sheriff. Suspect that the CL breaks components_unittests
on Mac.

https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.9%20Tests%...

Not sure. Will revert the revert if it does not help.

Original issue's description:
> Replace for loops with |arraysize| with for each loops
> 
> This change replaces for-loops involving a loop variable and the
> |arraysize| macro with a C++11 for-each-loop where appropriate.
> 
> A few usages of |arraysize| in a for-loop remain, in these the loop
> variable is used as well. This can be simply logging the iteration
> number or indexing another array of the same size.
> 
> BUG=655950
> 
> Committed: https://crrev.com/54e466c9fd2ff04136f8f305615910e8f9085642
> Cr-Commit-Position: refs/heads/master@{#425651}

TBR=vabr@chromium.org,jdoerrie@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=655950
==========

to

==========
Revert of Replace for loops with |arraysize| with for each loops (patchset #2
id:20001 of https://codereview.chromium.org/2417783004/ )

Reason for revert:
Speculative revert from sheriff. Suspect that the CL breaks components_unittests
on Mac.

https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.9%20Tests%...

Not sure. Will revert the revert if it does not help.

Original issue's description:
> Replace for loops with |arraysize| with for each loops
>
> This change replaces for-loops involving a loop variable and the
> |arraysize| macro with a C++11 for-each-loop where appropriate.
>
> A few usages of |arraysize| in a for-loop remain, in these the loop
> variable is used as well. This can be simply logging the iteration
> number or indexing another array of the same size.
>
> BUG=655950
>
> Committed: https://crrev.com/54e466c9fd2ff04136f8f305615910e8f9085642
> Cr-Commit-Position: refs/heads/master@{#425651}

TBR=vabr@chromium.org,jdoerrie@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=655950

Committed: https://crrev.com/e00a337f9c62d1d32c315ecacc63cec380a36e27
Cr-Commit-Position: refs/heads/master@{#425660}
==========

[commit-bot: I haz the power, 2016-10-17 12:19:12]

Patchset 1 (id:??) landed as
https://crrev.com/e00a337f9c62d1d32c315ecacc63cec380a36e27
Cr-Commit-Position: refs/heads/master@{#425660}

[jdoerrie, 2016-11-03 13:47:49]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2478463002/ by jdoerrie@chromium.org.

The reason for reverting is: Relanding, because the flaky unittest was fixed:
http://crbug.com/656926.