Revert of Replace for loops with |arraysize| with for each loops

components/autofill/core/browser/validation_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stddef.h>
 
 #include "base/macros.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/time/time.h"
 #include "components/autofill/core/browser/validation.h"
@@ skipping 74 matching lines @@
   "user@",
   "user@=example.com"
 };
 const char kAmericanExpressCard[] = "341111111111111";
 const char kVisaCard[] = "4111111111111111";
 const char kAmericanExpressCVC[] = "1234";
 const char kVisaCVC[] = "123";
 }  // namespace
 
 TEST(AutofillValidation, IsValidCreditCardNumber) {
-  for (const char* valid_number : kValidNumbers) {
-    SCOPED_TRACE(valid_number);
-    EXPECT_TRUE(IsValidCreditCardNumber(ASCIIToUTF16(valid_number)));
+  for (size_t i = 0; i < arraysize(kValidNumbers); ++i) {
+    SCOPED_TRACE(kValidNumbers[i]);
+    EXPECT_TRUE(
+        IsValidCreditCardNumber(ASCIIToUTF16(kValidNumbers[i])));
   }
-  for (const char* invalid_number : kInvalidNumbers) {
-    SCOPED_TRACE(invalid_number);
-    EXPECT_FALSE(IsValidCreditCardNumber(ASCIIToUTF16(invalid_number)));
+  for (size_t i = 0; i < arraysize(kInvalidNumbers); ++i) {
+    SCOPED_TRACE(kInvalidNumbers[i]);
+    EXPECT_FALSE(IsValidCreditCardNumber(ASCIIToUTF16(kInvalidNumbers[i])));
   }
 }
 
 TEST(AutofillValidation, IsValidCreditCardIntExpirationDate) {
   base::Time now;
   ASSERT_TRUE(base::Time::FromString(kCurrentDate, &now));
 
-  for (const IntExpirationDate& data : kValidCreditCardIntExpirationDate) {
+  for (size_t i = 0; i < arraysize(kValidCreditCardIntExpirationDate); ++i) {
+    const IntExpirationDate& data = kValidCreditCardIntExpirationDate[i];
     SCOPED_TRACE(data.year);
     SCOPED_TRACE(data.month);
     EXPECT_TRUE(IsValidCreditCardExpirationDate(data.year, data.month, now));
   }
-  for (const IntExpirationDate& data : kInvalidCreditCardIntExpirationDate) {
+  for (size_t i = 0; i < arraysize(kInvalidCreditCardIntExpirationDate); ++i) {
+    const IntExpirationDate& data = kInvalidCreditCardIntExpirationDate[i];
     SCOPED_TRACE(data.year);
     SCOPED_TRACE(data.month);
     EXPECT_TRUE(!IsValidCreditCardExpirationDate(data.year, data.month, now));
   }
 }
 TEST(AutofillValidation, IsValidCreditCardSecurityCode) {
-  for (const char* valid_code : kValidCreditCardSecurityCode) {
-    SCOPED_TRACE(valid_code);
-    EXPECT_TRUE(IsValidCreditCardSecurityCode(ASCIIToUTF16(valid_code)));
+  for (size_t i = 0; i < arraysize(kValidCreditCardSecurityCode); ++i) {
+    SCOPED_TRACE(kValidCreditCardSecurityCode[i]);
+    EXPECT_TRUE(IsValidCreditCardSecurityCode(
+        ASCIIToUTF16(kValidCreditCardSecurityCode[i])));
   }
-  for (const char* invalid_code : kInvalidCreditCardSecurityCode) {
-    SCOPED_TRACE(invalid_code);
-    EXPECT_FALSE(IsValidCreditCardSecurityCode(ASCIIToUTF16(invalid_code)));
+  for (size_t i = 0; i < arraysize(kInvalidCreditCardSecurityCode); ++i) {
+    SCOPED_TRACE(kInvalidCreditCardSecurityCode[i]);
+    EXPECT_FALSE(IsValidCreditCardSecurityCode(
+        ASCIIToUTF16(kInvalidCreditCardSecurityCode[i])));
   }
 }
 
 TEST(AutofillValidation, IsValidEmailAddress) {
-  for (const char* valid_email : kValidEmailAddress) {
-    SCOPED_TRACE(valid_email);
-    EXPECT_TRUE(IsValidEmailAddress(ASCIIToUTF16(valid_email)));
+  for (size_t i = 0; i < arraysize(kValidEmailAddress); ++i) {
+    SCOPED_TRACE(kValidEmailAddress[i]);
+    EXPECT_TRUE(IsValidEmailAddress(ASCIIToUTF16(kValidEmailAddress[i])));
   }
-  for (const char* invalid_email : kInvalidEmailAddress) {
-    SCOPED_TRACE(invalid_email);
-    EXPECT_FALSE(IsValidEmailAddress(ASCIIToUTF16(invalid_email)));
+  for (size_t i = 0; i < arraysize(kInvalidEmailAddress); ++i) {
+    SCOPED_TRACE(kInvalidEmailAddress[i]);
+    EXPECT_FALSE(IsValidEmailAddress(ASCIIToUTF16(kInvalidEmailAddress[i])));
   }
 }
 
 TEST(AutofillValidation, IsValidCreditCardSecurityCodeWithNumber) {
   EXPECT_TRUE(IsValidCreditCardSecurityCode(
       ASCIIToUTF16(kAmericanExpressCVC), ASCIIToUTF16(kAmericanExpressCard)));
   EXPECT_TRUE(IsValidCreditCardSecurityCode(
       ASCIIToUTF16(kVisaCVC), ASCIIToUTF16(kVisaCard)));
   EXPECT_FALSE(IsValidCreditCardSecurityCode(
       ASCIIToUTF16(kVisaCVC), ASCIIToUTF16(kAmericanExpressCard)));
   EXPECT_FALSE(IsValidCreditCardSecurityCode(
       ASCIIToUTF16(kAmericanExpressCVC), ASCIIToUTF16(kVisaCard)));
   EXPECT_TRUE(IsValidCreditCardSecurityCode(
       ASCIIToUTF16(kVisaCVC), ASCIIToUTF16(kInvalidNumbers[0])));
   EXPECT_FALSE(IsValidCreditCardSecurityCode(
       ASCIIToUTF16(kAmericanExpressCVC), ASCIIToUTF16(kInvalidNumbers[0])));
 }
 
 }  // namespace autofill