sdk/lib/_internal/pub/lib/src/source/path.dart - Issue 24246002: Lazily throw pubspec parsing exceptions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/pub/lib/src/source/path.dart

Issue 24246002: Lazily throw pubspec parsing exceptions. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Code review changes Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sdk/lib/_internal/pub/lib/src/source/path.dart

diff --git a/sdk/lib/_internal/pub/lib/src/source/path.dart b/sdk/lib/_internal/pub/lib/src/source/path.dart

index d007f2e69747e233e87b8a2273d2eb695bedc679..a9a88d8f9d448245e47e6fffcfa1e433b1d85069 100644

--- a/sdk/lib/_internal/pub/lib/src/source/path.dart

+++ b/sdk/lib/_internal/pub/lib/src/source/path.dart

@@ -22,8 +22,8 @@ class PathSource extends Source {

Future<Pubspec> describeUncached(PackageId id) {

return new Future.sync(() {

_validatePath(id.name, id.description);

- return new Pubspec.load(id.name, id.description["path"],

- systemCache.sources);

+ return new Pubspec.load(id.description["path"], systemCache.sources,

+ expectedName: id.name);

});

}