sdk/lib/_internal/pub/lib/src/source/hosted.dart - Issue 24246002: Lazily throw pubspec parsing exceptions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/pub/lib/src/source/hosted.dart

Issue 24246002: Lazily throw pubspec parsing exceptions. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Code review changes Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sdk/lib/_internal/pub/lib/src/source/hosted.dart

diff --git a/sdk/lib/_internal/pub/lib/src/source/hosted.dart b/sdk/lib/_internal/pub/lib/src/source/hosted.dart

index b2c1647cebab86b4979bcbf9f65934f9a5a8e4fe..af110e6f582d35cd24433fffe5c0c75c7b549be5 100644

--- a/sdk/lib/_internal/pub/lib/src/source/hosted.dart

+++ b/sdk/lib/_internal/pub/lib/src/source/hosted.dart

@@ -71,7 +71,8 @@ class HostedSource extends Source {

// a secondary cache of just pubspecs. This would let us have a

// persistent cache for pubspecs for packages that haven't actually

// been installed.

- return new Pubspec.fromMap(version['pubspec'], systemCache.sources);

+ return new Pubspec.fromMap(version['pubspec'], systemCache.sources,

+ expectedName: id.name, location: url);

}).catchError((ex) {

var parsed = _parseDescription(id.description);

_throwFriendlyError(ex, id, parsed.last);