Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2424373002: Remove aria hide attribute on the network error interstitial error code (Closed)

Created:
4 years, 2 months ago by edwardjung
Modified:
4 years, 2 months ago
Reviewers:
mmenke
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove aria hide attribute on the network error interstitial error code BUG=606976 Committed: https://crrev.com/8f5d8cb0f950a84f33f0b7230bfded6fd5a9ecce Cr-Commit-Position: refs/heads/master@{#425970}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M components/neterror/resources/neterror.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
edwardjung
PTAL, per accessibility review, reverting the hiding of the error code for screen readers.
4 years, 2 months ago (2016-10-18 09:28:52 UTC) #2
mmenke
On 2016/10/18 09:28:52, edwardjung wrote: > PTAL, per accessibility review, reverting the hiding of the ...
4 years, 2 months ago (2016-10-18 14:30:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2424373002/1
4 years, 2 months ago (2016-10-18 15:33:31 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-18 15:38:45 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-18 15:40:35 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/8f5d8cb0f950a84f33f0b7230bfded6fd5a9ecce
Cr-Commit-Position: refs/heads/master@{#425970}

Powered by Google App Engine
This is Rietveld 408576698