third_party/WebKit/LayoutTests/bluetooth/getPrimaryService/gen-service-device-disconnects-before.html - Issue 2423853002: bluetooth: Add script to generate tests based on templates

Unified Diff: third_party/WebKit/LayoutTests/bluetooth/getPrimaryService/gen-service-device-disconnects-before.html

Issue 2423853002: bluetooth: Add script to generate tests based on templates (Closed)

Patch Set: Clean up Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« third_party/WebKit/LayoutTests/bluetooth/generate_test.py ('K') | « third_party/WebKit/LayoutTests/bluetooth/getPrimaryService/device-disconnects-before.html ('k') | third_party/WebKit/LayoutTests/bluetooth/getPrimaryServices/device-disconnects-before.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/bluetooth/getPrimaryService/gen-service-device-disconnects-before.html

diff --git a/third_party/WebKit/LayoutTests/bluetooth/getPrimaryService/device-disconnects-before.html b/third_party/WebKit/LayoutTests/bluetooth/getPrimaryService/gen-service-device-disconnects-before.html

similarity index 63%

rename from third_party/WebKit/LayoutTests/bluetooth/getPrimaryService/device-disconnects-before.html

rename to third_party/WebKit/LayoutTests/bluetooth/getPrimaryService/gen-service-device-disconnects-before.html

index 817f79e16d208bb24f3d6d9610f93bc266f4b59a..6b4a04c7ac34d410b64ffb8094a8679d42021e15 100644

--- a/third_party/WebKit/LayoutTests/bluetooth/getPrimaryService/device-disconnects-before.html

+++ b/third_party/WebKit/LayoutTests/bluetooth/getPrimaryService/gen-service-device-disconnects-before.html

@@ -1,3 +1,4 @@

+

<!DOCTYPE html>

@@ -12,13 +13,18 @@ promise_test(t => {

}))

.then(device => {

return device.gatt.connect()

- .then(gattServer => gattServer.getPrimaryService(request_disconnection_service_uuid))

- .then(service => service.getCharacteristic(request_disconnection_characteristic_uuid))

- .then(requestDisconnection => requestDisconnection.writeValue(new Uint8Array([0])))

+ .then(gattServer => gattServer.getPrimaryService(

+ request_disconnection_service_uuid))

+ .then(service => service.getCharacteristic(

+ request_disconnection_characteristic_uuid))

+ .then(requestDisconnection => requestDisconnection.writeValue(

Jeffrey Yasskin 2016/10/19 01:39:24 Can you also arrange to generate the "disconnect b

ortuno 2016/10/19 04:34:04 I think there might be too many differences betwee

Jeffrey Yasskin 2016/10/19 22:33:29 Yeah, it might be something semantically like: fo

ortuno 2016/10/20 00:27:03 Acknowledged.

+ new Uint8Array([0])))

.then(() => assert_promise_rejects_with_message(

device.gatt.getPrimaryService('heart_rate'),

- new DOMException('GATT Server is disconnected. Cannot retrieve services.',

- 'NetworkError')));

+ new DOMException(

+ 'GATT Server is disconnected. Cannot retrieve services.',

+ 'NetworkError')));

});

}, 'Device disconnects before getPrimaryService. Reject with NetworkError.');

</script>