third_party/WebKit/LayoutTests/bluetooth/getPrimaryService/gen-service-device-disconnects-before.html - Issue 2423853002: bluetooth: Add script to generate tests based on templates

Side by Side Diff: third_party/WebKit/LayoutTests/bluetooth/getPrimaryService/gen-service-device-disconnects-before.html

Issue 2423853002: bluetooth: Add script to generate tests based on templates (Closed)

Patch Set: Clean up Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« third_party/WebKit/LayoutTests/bluetooth/generate_test.py ('K') | « third_party/WebKit/LayoutTests/bluetooth/getPrimaryService/device-disconnects-before.html ('k') | third_party/WebKit/LayoutTests/bluetooth/getPrimaryServices/device-disconnects-before.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
	1 <!-- Generated by //third_party/WebKit/LayoutTests/bluetooth/generate.py -->

1 <!DOCTYPE html>	2 <!DOCTYPE html>

2 <script src="../../resources/testharness.js"></script>	3 <script src="../../resources/testharness.js"></script>

3 <script src="../../resources/testharnessreport.js"></script>	4 <script src="../../resources/testharnessreport.js"></script>

4 <script src="../../resources/bluetooth/bluetooth-helpers.js"></script>	5 <script src="../../resources/bluetooth/bluetooth-helpers.js"></script>

5 <script>	6 <script>

6 'use strict';	7 'use strict';

7 promise_test(t => {	8 promise_test(t => {

8 return setBluetoothFakeAdapter('DisconnectingHeartRateAdapter')	9 return setBluetoothFakeAdapter('DisconnectingHeartRateAdapter')

9 .then(() => requestDeviceWithKeyDown({	10 .then(() => requestDeviceWithKeyDown({

10 filters: [{services: ['heart_rate']}],	11 filters: [{services: ['heart_rate']}],

11 optionalServices: [request_disconnection_service_uuid]	12 optionalServices: [request_disconnection_service_uuid]

12 }))	13 }))

13 .then(device => {	14 .then(device => {

14 return device.gatt.connect()	15 return device.gatt.connect()

15 .then(gattServer => gattServer.getPrimaryService(request_disconnection_s ervice_uuid))	16 .then(gattServer => gattServer.getPrimaryService(

16 .then(service => service.getCharacteristic(request_disconnection_charact eristic_uuid))	17 request_disconnection_service_uuid))

17 .then(requestDisconnection => requestDisconnection.writeValue(new Uint8A rray([0])))	18 .then(service => service.getCharacteristic(

	19 request_disconnection_characteristic_uuid))

	20 .then(requestDisconnection => requestDisconnection.writeValue(
	Jeffrey Yasskin 2016/10/19 01:39:24 Can you also arrange to generate the "disconnect b Can you also arrange to generate the "disconnect before vs during" axis of tests? ortuno 2016/10/19 04:34:04 I think there might be too many differences betwee Show quoted text On 2016/10/19 at 01:39:24, Jeffrey Yasskin wrote: > Can you also arrange to generate the "disconnect before vs during" axis of tests? I think there might be too many differences between each variation that would introduce too much complexity in the script. So there are two types of disconnects: developer initiated and device initiated. For developer initiated there are three types of tests: - disconnect-called-before - disconnect-called-during-success - disconnect-called-during-error For each function variation e.g. getPrimaryService we need a different argument and a different error message. So I think we would need to start nesting tokens: DISCONNECT([ BEFORE([ {'call1', 'error type1', 'error message1'}, {'call2', 'error type2', 'error message2'} ]), DURING_SUCCESS([ {'call1', 'error type1', 'error message1'}, {'call2', 'error type2', 'error message2'} ]), DURING_ERROR([ {'call1', 'error type1', 'error message1'}, {'call2', 'error type2', 'error message2'} ]) ]) Jeffrey Yasskin 2016/10/19 22:33:29 Yeah, it might be something semantically like: fo Show quoted text On 2016/10/19 04:34:04, ortuno wrote: > On 2016/10/19 at 01:39:24, Jeffrey Yasskin wrote: > > Can you also arrange to generate the "disconnect before vs during" axis of > tests? > > I think there might be too many differences between each variation that would > introduce too much complexity in the script. > > So there are two types of disconnects: developer initiated and device initiated. > > For developer initiated there are three types of tests: > - disconnect-called-before > - disconnect-called-during-success > - disconnect-called-during-error > > For each function variation e.g. getPrimaryService we need a different argument > and a different error message. > > So I think we would need to start nesting tokens: > > DISCONNECT([ > BEFORE([ > {'call1', 'error type1', 'error message1'}, > {'call2', 'error type2', 'error message2'} > ]), > DURING_SUCCESS([ > {'call1', 'error type1', 'error message1'}, > {'call2', 'error type2', 'error message2'} > ]), > DURING_ERROR([ > {'call1', 'error type1', 'error message1'}, > {'call2', 'error type2', 'error message2'} > ]) > ]) Yeah, it might be something semantically like: for (VAR1, VAR2, VAR3) of [ ('call1', 'error type 1', message 1'), (...), ...]: for (VAR4, VAR5) of [ ('', 'content'), ('other content', ''): let FILENAME = VAR1 + VAR4 ?? https://github.com/google/googletest/blob/master/googletest/scripts/pump.py does some of this sort of thing, but can't generate multiple files. It probably makes sense to generalize this later instead of now. ortuno 2016/10/20 00:27:03 Acknowledged. Show quoted text On 2016/10/19 at 22:33:29, Jeffrey Yasskin wrote: > On 2016/10/19 04:34:04, ortuno wrote: > > On 2016/10/19 at 01:39:24, Jeffrey Yasskin wrote: > > > Can you also arrange to generate the "disconnect before vs during" axis of > > tests? > > > > I think there might be too many differences between each variation that would > > introduce too much complexity in the script. > > > > So there are two types of disconnects: developer initiated and device initiated. > > > > For developer initiated there are three types of tests: > > - disconnect-called-before > > - disconnect-called-during-success > > - disconnect-called-during-error > > > > For each function variation e.g. getPrimaryService we need a different argument > > and a different error message. > > > > So I think we would need to start nesting tokens: > > > > DISCONNECT([ > > BEFORE([ > > {'call1', 'error type1', 'error message1'}, > > {'call2', 'error type2', 'error message2'} > > ]), > > DURING_SUCCESS([ > > {'call1', 'error type1', 'error message1'}, > > {'call2', 'error type2', 'error message2'} > > ]), > > DURING_ERROR([ > > {'call1', 'error type1', 'error message1'}, > > {'call2', 'error type2', 'error message2'} > > ]) > > ]) > > Yeah, it might be something semantically like: > > for (VAR1, VAR2, VAR3) of [ ('call1', 'error type 1', message 1'), (...), ...]: > for (VAR4, VAR5) of [ ('', 'content'), ('other content', ''): > let FILENAME = VAR1 + VAR4 > > > ?? https://github.com/google/googletest/blob/master/googletest/scripts/pump.py does some of this sort of thing, but can't generate multiple files. > > > It probably makes sense to generalize this later instead of now. Acknowledged.
	21 new Uint8Array([0])))

18 .then(() => assert_promise_rejects_with_message(	22 .then(() => assert_promise_rejects_with_message(

19 device.gatt.getPrimaryService('heart_rate'),	23 device.gatt.getPrimaryService('heart_rate'),

20 new DOMException('GATT Server is disconnected. Cannot retrieve service s.',	24 new DOMException(

21 'NetworkError')));	25 'GATT Server is disconnected. Cannot retrieve services.',

	26 'NetworkError')));

22 });	27 });

23 }, 'Device disconnects before getPrimaryService. Reject with NetworkError.');	28 }, 'Device disconnects before getPrimaryService. Reject with NetworkError.');

	29

24 </script>	30 </script>

OLD	NEW