Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 2423813002: Remove usage of FOR_EACH_OBSERVER macro in components/history (Closed)

Created:
4 years, 2 months ago by Eric Willigers
Modified:
4 years, 2 months ago
Reviewers:
sky
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove usage of FOR_EACH_OBSERVER macro in components/history Observer lists now support range-based for loops. BUG=655021 Committed: https://crrev.com/720393e91b2cfe204d8ceee35c9b0b4dad69d2ce Cr-Commit-Position: refs/heads/master@{#425848}

Patch Set 1 #

Patch Set 2 : explicit type #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -27 lines) Patch
M components/history/core/browser/history_backend.cc View 1 2 chunks +8 lines, -7 lines 0 comments Download
M components/history/core/browser/history_service.cc View 1 3 chunks +16 lines, -15 lines 0 comments Download
M components/history/core/browser/top_sites.cc View 1 1 chunk +4 lines, -3 lines 0 comments Download
M components/history/core/browser/web_history_service.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
Eric Willigers
4 years, 2 months ago (2016-10-17 00:50:36 UTC) #4
sky
Similar request about using type.
4 years, 2 months ago (2016-10-17 15:55:25 UTC) #7
Eric Willigers
On 2016/10/17 15:55:25, sky wrote: > Similar request about using type. Done. PTAL.
4 years, 2 months ago (2016-10-17 23:39:26 UTC) #8
sky
LGTM
4 years, 2 months ago (2016-10-17 23:50:29 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2423813002/20001
4 years, 2 months ago (2016-10-17 23:54:12 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-18 01:25:57 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-10-18 01:28:20 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/720393e91b2cfe204d8ceee35c9b0b4dad69d2ce
Cr-Commit-Position: refs/heads/master@{#425848}

Powered by Google App Engine
This is Rietveld 408576698