Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Unified Diff: components/history/core/browser/history_backend.cc

Issue 2423813002: Remove usage of FOR_EACH_OBSERVER macro in components/history (Closed)
Patch Set: explicit type Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/history/core/browser/history_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/history/core/browser/history_backend.cc
diff --git a/components/history/core/browser/history_backend.cc b/components/history/core/browser/history_backend.cc
index 50383baf27d5b2e8e65f2c573ae4e6787671ff30..410f2588dfef829ba84db98331eae5dc0601d450 100644
--- a/components/history/core/browser/history_backend.cc
+++ b/components/history/core/browser/history_backend.cc
@@ -2492,16 +2492,16 @@ void HistoryBackend::NotifyURLVisited(ui::PageTransition transition,
const URLRow& row,
const RedirectList& redirects,
base::Time visit_time) {
- FOR_EACH_OBSERVER(HistoryBackendObserver, observers_,
- OnURLVisited(this, transition, row, redirects, visit_time));
+ for (HistoryBackendObserver& observer : observers_)
+ observer.OnURLVisited(this, transition, row, redirects, visit_time);
if (delegate_)
delegate_->NotifyURLVisited(transition, row, redirects, visit_time);
}
void HistoryBackend::NotifyURLsModified(const URLRows& rows) {
- FOR_EACH_OBSERVER(HistoryBackendObserver, observers_,
- OnURLsModified(this, rows));
+ for (HistoryBackendObserver& observer : observers_)
+ observer.OnURLsModified(this, rows);
if (delegate_)
delegate_->NotifyURLsModified(rows);
@@ -2512,9 +2512,10 @@ void HistoryBackend::NotifyURLsDeleted(bool all_history,
const URLRows& rows,
const std::set<GURL>& favicon_urls) {
URLRows copied_rows(rows);
- FOR_EACH_OBSERVER(
- HistoryBackendObserver, observers_,
- OnURLsDeleted(this, all_history, expired, copied_rows, favicon_urls));
+ for (HistoryBackendObserver& observer : observers_) {
+ observer.OnURLsDeleted(this, all_history, expired, copied_rows,
+ favicon_urls);
+ }
if (delegate_)
delegate_->NotifyURLsDeleted(all_history, expired, copied_rows,
« no previous file with comments | « no previous file | components/history/core/browser/history_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698