Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 2423793002: Remove usage of FOR_EACH_OBSERVER macro in device/ (Closed)

Created:
4 years, 2 months ago by Eric Willigers
Modified:
4 years, 2 months ago
CC:
chromium-reviews, mac-reviews_chromium.org, ortuno+watch_chromium.org, scheib+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove usage of FOR_EACH_OBSERVER macro in device/ Observer lists now support range-based for loops. BUG=655021 Committed: https://crrev.com/98f5411faa0c4ab9993073664ac05feda1fd03d5 Cr-Commit-Position: refs/heads/master@{#426104}

Patch Set 1 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+222 lines, -222 lines) Patch
M device/bluetooth/bluetooth_adapter.cc View 7 chunks +30 lines, -31 lines 0 comments Download
M device/bluetooth/bluetooth_adapter_android.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M device/bluetooth/bluetooth_adapter_mac.mm View 6 chunks +14 lines, -16 lines 0 comments Download
M device/bluetooth/bluetooth_adapter_win.cc View 6 chunks +14 lines, -15 lines 0 comments Download
M device/bluetooth/bluetooth_task_manager_win.cc View 1 chunk +8 lines, -8 lines 0 comments Download
M device/bluetooth/bluez/bluetooth_adapter_bluez.cc View 5 chunks +14 lines, -14 lines 0 comments Download
M device/bluetooth/bluez/bluetooth_advertisement_bluez.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M device/bluetooth/dbus/bluetooth_adapter_client.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M device/bluetooth/dbus/bluetooth_device_client.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M device/bluetooth/dbus/bluetooth_gatt_characteristic_client.cc View 2 chunks +6 lines, -7 lines 0 comments Download
M device/bluetooth/dbus/bluetooth_gatt_descriptor_client.cc View 2 chunks +6 lines, -7 lines 0 comments Download
M device/bluetooth/dbus/bluetooth_gatt_service_client.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M device/bluetooth/dbus/bluetooth_input_client.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M device/bluetooth/dbus/bluetooth_le_advertising_manager_client.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M device/bluetooth/dbus/bluetooth_media_client.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M device/bluetooth/dbus/bluetooth_media_transport_client.cc View 2 chunks +6 lines, -7 lines 0 comments Download
M device/bluetooth/dbus/fake_bluetooth_adapter_client.cc View 3 chunks +12 lines, -11 lines 0 comments Download
M device/bluetooth/dbus/fake_bluetooth_device_client.cc View 5 chunks +10 lines, -10 lines 0 comments Download
M device/bluetooth/dbus/fake_bluetooth_gatt_characteristic_client.cc View 1 chunk +6 lines, -7 lines 0 comments Download
M device/bluetooth/dbus/fake_bluetooth_gatt_descriptor_client.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M device/bluetooth/dbus/fake_bluetooth_gatt_service_client.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M device/bluetooth/dbus/fake_bluetooth_input_client.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M device/bluetooth/dbus/fake_bluetooth_media_client.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M device/bluetooth/dbus/fake_bluetooth_media_transport_client.cc View 3 chunks +10 lines, -10 lines 0 comments Download
M device/bluetooth/test/mock_bluetooth_gatt_notify_session.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M device/generic_sensor/platform_sensor.cc View 1 chunk +2 lines, -1 line 0 comments Download
M device/hid/hid_service.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M device/hid/input_service_linux.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M device/media_transfer_protocol/media_transfer_protocol_manager.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M device/usb/usb_device.cc View 1 chunk +2 lines, -1 line 0 comments Download
M device/usb/usb_service.cc View 2 chunks +8 lines, -4 lines 0 comments Download

Messages

Total messages: 17 (12 generated)
Eric Willigers
4 years, 2 months ago (2016-10-17 01:23:11 UTC) #9
Ken Rockot(use gerrit already)
lgtm
4 years, 2 months ago (2016-10-18 14:58:35 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2423793002/20001
4 years, 2 months ago (2016-10-18 22:44:30 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 2 months ago (2016-10-19 00:30:34 UTC) #15
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:05:23 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/98f5411faa0c4ab9993073664ac05feda1fd03d5
Cr-Commit-Position: refs/heads/master@{#426104}

Powered by Google App Engine
This is Rietveld 408576698