Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Unified Diff: device/bluetooth/dbus/bluetooth_gatt_characteristic_client.cc

Issue 2423793002: Remove usage of FOR_EACH_OBSERVER macro in device/ (Closed)
Patch Set: rebase Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: device/bluetooth/dbus/bluetooth_gatt_characteristic_client.cc
diff --git a/device/bluetooth/dbus/bluetooth_gatt_characteristic_client.cc b/device/bluetooth/dbus/bluetooth_gatt_characteristic_client.cc
index 1ce7c35bc0f70af6978edb9e1e3148ebf5850835..7423eb60cbf1cc20b93f2f4dbe56e1ba2bf89d4b 100644
--- a/device/bluetooth/dbus/bluetooth_gatt_characteristic_client.cc
+++ b/device/bluetooth/dbus/bluetooth_gatt_characteristic_client.cc
@@ -202,16 +202,16 @@ class BluetoothGattCharacteristicClientImpl
void ObjectAdded(const dbus::ObjectPath& object_path,
const std::string& interface_name) override {
VLOG(2) << "Remote GATT characteristic added: " << object_path.value();
- FOR_EACH_OBSERVER(BluetoothGattCharacteristicClient::Observer, observers_,
- GattCharacteristicAdded(object_path));
+ for (auto& observer : observers_)
+ observer.GattCharacteristicAdded(object_path);
}
// dbus::ObjectManager::Interface override.
void ObjectRemoved(const dbus::ObjectPath& object_path,
const std::string& interface_name) override {
VLOG(2) << "Remote GATT characteristic removed: " << object_path.value();
- FOR_EACH_OBSERVER(BluetoothGattCharacteristicClient::Observer, observers_,
- GattCharacteristicRemoved(object_path));
+ for (auto& observer : observers_)
+ observer.GattCharacteristicRemoved(object_path);
}
protected:
@@ -234,9 +234,8 @@ class BluetoothGattCharacteristicClientImpl
const std::string& property_name) {
VLOG(2) << "Remote GATT characteristic property changed: "
<< object_path.value() << ": " << property_name;
- FOR_EACH_OBSERVER(
- BluetoothGattCharacteristicClient::Observer, observers_,
- GattCharacteristicPropertyChanged(object_path, property_name));
+ for (auto& observer : observers_)
+ observer.GattCharacteristicPropertyChanged(object_path, property_name);
}
// Called when a response for successful method call is received.
« no previous file with comments | « device/bluetooth/dbus/bluetooth_device_client.cc ('k') | device/bluetooth/dbus/bluetooth_gatt_descriptor_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698