Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(812)

Issue 2423713002: Remove usage of FOR_EACH_OBSERVER macro in net (Closed)

Created:
4 years, 2 months ago by Eric Willigers
Modified:
4 years, 2 months ago
Reviewers:
Jana, agl
CC:
chromium-reviews, cbentzel+watch_chromium.org, eroman, tbansal+watch-nqe_chromium.org, mmenke, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove usage of FOR_EACH_OBSERVER macro in net Observer lists now support range-based for loops. BUG=655021 Committed: https://crrev.com/9d64a5f4c772200ddf5b7070e5a4c9d49e29a043 Cr-Commit-Position: refs/heads/master@{#425832}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -33 lines) Patch
M net/base/sdch_manager.cc View 4 chunks +10 lines, -9 lines 0 comments Download
M net/cert/sth_distributor.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/dns/mdns_client_impl.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M net/log/net_log.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/nqe/network_quality_store.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M net/proxy/polling_proxy_config_service.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M net/proxy/proxy_config_service_android.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M net/proxy/proxy_config_service_linux.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M net/proxy/proxy_config_service_mac.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/proxy/proxy_service_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/ssl/ssl_config_service.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/url_request/url_request_context_getter.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
Eric Willigers
4 years, 2 months ago (2016-10-15 13:06:43 UTC) #6
Eric Willigers
4 years, 2 months ago (2016-10-17 22:31:34 UTC) #8
agl
lgtm
4 years, 2 months ago (2016-10-17 22:48:20 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2423713002/1
4 years, 2 months ago (2016-10-17 22:53:04 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-18 00:29:14 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-10-18 00:33:09 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9d64a5f4c772200ddf5b7070e5a4c9d49e29a043
Cr-Commit-Position: refs/heads/master@{#425832}

Powered by Google App Engine
This is Rietveld 408576698