net/nqe/network_quality_store.cc - Issue 2423713002: Remove usage of FOR_EACH_OBSERVER macro in net

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/nqe/network_quality_store.cc

Issue 2423713002: Remove usage of FOR_EACH_OBSERVER macro in net (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/nqe/network_quality_store.cc

diff --git a/net/nqe/network_quality_store.cc b/net/nqe/network_quality_store.cc

index 7a1c253bdbaf7af91de5f69f800dc46c11e56c5c..01b50054a5e758e6757633c0d723063dd8c5b0d1 100644

--- a/net/nqe/network_quality_store.cc

+++ b/net/nqe/network_quality_store.cc

@@ -60,9 +60,8 @@ void NetworkQualityStore::Add(

DCHECK_LE(cached_network_qualities_.size(),

static_cast<size_t>(kMaximumNetworkQualityCacheSize));

- FOR_EACH_OBSERVER(

- NetworkQualitiesCacheObserver, network_qualities_cache_observer_list_,

- OnChangeInCachedNetworkQuality(network_id, cached_network_quality));

+ for (auto& observer : network_qualities_cache_observer_list_)

+ observer.OnChangeInCachedNetworkQuality(network_id, cached_network_quality);

}

bool NetworkQualityStore::GetById(

« no previous file with comments | « net/log/net_log.cc ('k') | net/proxy/polling_proxy_config_service.cc » ('j') | no next file with comments »