Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(849)

Unified Diff: third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp

Issue 2423683002: Add Blink support for showing image placeholders using range requests. (Closed)
Patch Set: Addressed comments Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp
diff --git a/third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp b/third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp
index 5105488d1075419512ef874a4c21adde757db359..356d57a89d07e7a79df2ac1f4acbf1868e56c9c9 100644
--- a/third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp
+++ b/third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp
@@ -1164,6 +1164,11 @@ void ResourceFetcher::didFinishLoading(Resource* resource,
if (finishReason == DidFinishLoading)
resource->finish(finishTime);
context().didLoadResource(resource);
+
+ if (resource->isImage() &&
+ toImageResource(resource)->shouldReloadBrokenPlaceholder()) {
+ toImageResource(resource)->reloadIfLoFiOrPlaceholder(this);
+ }
}
void ResourceFetcher::didFailLoading(Resource* resource,
@@ -1176,6 +1181,11 @@ void ResourceFetcher::didFailLoading(Resource* resource,
context().dispatchDidFail(resource->identifier(), error, isInternalRequest);
resource->error(error);
context().didLoadResource(resource);
+
+ if (resource->isImage() &&
+ toImageResource(resource)->shouldReloadBrokenPlaceholder()) {
+ toImageResource(resource)->reloadIfLoFiOrPlaceholder(this);
+ }
}
void ResourceFetcher::didReceiveResponse(Resource* resource,
@@ -1423,7 +1433,7 @@ void ResourceFetcher::reloadLoFiImages() {
Resource* resource = documentResource.value.get();
if (resource && resource->isImage()) {
ImageResource* imageResource = toImageResource(resource);
- imageResource->reloadIfLoFi(this);
+ imageResource->reloadIfLoFiOrPlaceholder(this);
}
}
}

Powered by Google App Engine
This is Rietveld 408576698