Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(566)

Unified Diff: third_party/WebKit/Source/core/loader/ProgressTracker.cpp

Issue 2423683002: Add Blink support for showing image placeholders using range requests. (Closed)
Patch Set: Addressed comments Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/loader/ProgressTracker.cpp
diff --git a/third_party/WebKit/Source/core/loader/ProgressTracker.cpp b/third_party/WebKit/Source/core/loader/ProgressTracker.cpp
index 69833e777b26c7a801b154337a6c9eda3a3a64ee..23721d408a8655bf7ce55a2d5487dddb75705c1f 100644
--- a/third_party/WebKit/Source/core/loader/ProgressTracker.cpp
+++ b/third_party/WebKit/Source/core/loader/ProgressTracker.cpp
@@ -141,7 +141,6 @@ void ProgressTracker::willStartLoading(unsigned long identifier,
ProgressBarCompletion::LoadEvent &&
(m_finishedParsing || priority < ResourceLoadPriorityHigh))
return;
- DCHECK(!m_progressItems.get(identifier));
Nate Chapin 2016/10/21 18:23:55 I missed this...when does this DCHECK get hit? Thi
sclittle 2016/10/21 18:57:25 The ProgressTracker doesn't remove resources from
Nate Chapin 2016/10/21 19:13:10 Fair enough. I'm debating whether it's better to d
m_progressItems.set(
identifier,
wrapUnique(new ProgressItem(progressItemDefaultEstimatedLength)));

Powered by Google App Engine
This is Rietveld 408576698