Issue 2423673002: [Merge to M55] Fix regression in handling toggle mirror mode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2423673002: [Merge to M55] Fix regression in handling toggle mirror mode (Closed)

Created:
4 years, 2 months ago by afakhry

Modified:
4 years, 2 months ago

Reviewers:
James Cook

CC:
chromium-reviews, kalyank, sadrul

Target Ref:
refs/pending/branch-heads/2883

Project:
chromium

Visibility:
Public.

[Merge to M55] Fix regression in handling toggle mirror mode Toggle mirror mode shouldn't be dependent on the dev-shortcuts flag. TBR=jamescook@chromium.org BUG=650394 TEST=Ctrl+F4 should toggle mirror mode successfully. Review-Url: https://codereview.chromium.org/2417773002 Cr-Commit-Position: refs/heads/master@{#425189} (cherry picked from commit d8b394e863e69c0b99338e826a05fae76f22851a) Committed: https://chromium.googlesource.com/chromium/src/+/4c87bb9fb0e725ad22520dc27847bfb577be535d

Created: 4 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	ash/accelerators/accelerator_controller_delegate_aura.cc	View		2 chunks	+1 line, -1 line	0 comments	Download

Total messages: 2 (1 generated)

afakhry

4 years, 2 months ago (2016-10-15 01:45:49 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
4c87bb9fb0e725ad22520dc27847bfb577be535d (presubmit successful).