Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(761)

Issue 2417773002: Fix regression in handling toggle mirror mode (Closed)

Created:
4 years, 2 months ago by afakhry
Modified:
4 years, 2 months ago
Reviewers:
James Cook
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix regression in handling toggle mirror mode Toggle mirror mode shouldn't be dependent on the dev-shortcuts flag. BUG=650394 TEST=Ctrl+F4 should toggle mirror mode successfully. Committed: https://crrev.com/d8b394e863e69c0b99338e826a05fae76f22851a Cr-Commit-Position: refs/heads/master@{#425189}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ash/accelerators/accelerator_controller_delegate_aura.cc View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (7 generated)
afakhry
Oshima-san, please review. Thank you!
4 years, 2 months ago (2016-10-13 01:12:15 UTC) #2
afakhry
Oshima is OOO. James can you please take a look? Thanks!
4 years, 2 months ago (2016-10-13 17:19:21 UTC) #6
James Cook
lgtm
4 years, 2 months ago (2016-10-13 21:53:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2417773002/1
4 years, 2 months ago (2016-10-13 21:55:39 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-13 22:23:02 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-10-13 22:26:42 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d8b394e863e69c0b99338e826a05fae76f22851a
Cr-Commit-Position: refs/heads/master@{#425189}

Powered by Google App Engine
This is Rietveld 408576698