Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 2423433002: [Merge] Remove restrictive format pattern for Fontconfig matching (Closed)

Created:
4 years, 2 months ago by drott
Modified:
4 years, 2 months ago
CC:
reviews_skia.org
Target Ref:
refs/heads/chrome/m55
Project:
skia
Visibility:
Public.

Description

Remove restrictive format pattern for Fontconfig matching This pattern pushes CFF fonts too far low in the list. Instead it is enough to rely on the isValidPattern function to skip Type 1 fonts. Merged to m55 branch in order to unblock chromium:649468 BUG=skia:5846 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2410063002 Review-Url: https://codereview.chromium.org/2410063002 NOTREECHECKS=true NOTRY=true NOPRESUBMIT=true Committed: https://skia.googlesource.com/skia/+/fa25b331c7df93bc4940aafaac7b083e44ca777a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M src/ports/SkFontConfigInterface_direct.cpp View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
drott
Please commit if it looks good to you. I checked the buildspec and it does ...
4 years, 2 months ago (2016-10-14 12:33:26 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2423433002/1
4 years, 2 months ago (2016-10-14 14:07:33 UTC) #10
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
4 years, 2 months ago (2016-10-14 14:07:34 UTC) #11
bungeman-skia
lgtm
4 years, 2 months ago (2016-10-14 14:07:36 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2423433002/1
4 years, 2 months ago (2016-10-14 14:08:21 UTC) #15
commit-bot: I haz the power
4 years, 2 months ago (2016-10-14 14:08:28 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/fa25b331c7df93bc4940aafaac7b083e44ca777a

Powered by Google App Engine
This is Rietveld 408576698