Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Issue 2410063002: Remove restrictive format pattern for Fontconfig matching (Closed)

Created:
4 years, 2 months ago by drott
Modified:
4 years, 2 months ago
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove restrictive format pattern for Fontconfig matching This pattern pushes CFF fonts too far low in the list. Instead it is enough to rely on the isValidPattern function to skip Type 1 fonts. BUG=skia:5846 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2410063002 Committed: https://skia.googlesource.com/skia/+/1c7805bb1c3030efd7a4c848133b4f19285a9df1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M src/ports/SkFontConfigInterface_direct.cpp View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
drott
4 years, 2 months ago (2016-10-11 12:27:42 UTC) #5
bungeman-skia
lgtm
4 years, 2 months ago (2016-10-11 16:02:27 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2410063002/1
4 years, 2 months ago (2016-10-11 16:02:32 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/1c7805bb1c3030efd7a4c848133b4f19285a9df1
4 years, 2 months ago (2016-10-11 16:03:49 UTC) #15
behdad
4 years, 2 months ago (2016-10-11 16:59:34 UTC) #16
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698