Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 2423373002: Revert of Bump Chrome's deployment target to macOS 10.8. (Closed)

Created:
4 years, 2 months ago by Guido Urdaneta
Modified:
4 years, 2 months ago
Reviewers:
erikchen, Nico
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Bump Chrome's deployment target to macOS 10.8. (patchset #2 id:20001 of https://codereview.chromium.org/2420233002/ ) Reason for revert: Speculative revert. WebKit Mac Retina 10.10 bot broke and this is the only mac-specific CL in the blamelist. If the revert does not work, I will reland. https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11%20%28retina%29 Original issue's description: > Bump Chrome's deployment target to macOS 10.8. > > I also updated the comment to better reflect the relationship between Chrome and > its dependencies. Several Chrome dependencies require a different min sdk and/or > deployment target from Chrome. > > BUG=622481 > > Committed: https://crrev.com/3dade40fe88881864a42134f92238a6d292d8505 > Cr-Commit-Position: refs/heads/master@{#425870} TBR=thakis@chromium.org,erikchen@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=622481

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M build_overrides/build.gni View 2 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Guido Urdaneta
Created Revert of Bump Chrome's deployment target to macOS 10.8.
4 years, 2 months ago (2016-10-18 08:59:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2423373002/1
4 years, 2 months ago (2016-10-18 09:00:15 UTC) #3
commit-bot: I haz the power
4 years, 2 months ago (2016-10-18 09:01:29 UTC) #5
Failed to apply the patch.
On branch working_branch
Your branch is up-to-date with 'origin/refs/pending/heads/master'.
nothing to commit, working tree clean

Powered by Google App Engine
This is Rietveld 408576698