Fixed compilation errors in vulkan_renderer.h with enable_vulkan Flag.

Fixed compilation errors in vulkan_renderer.h with enable_vulkan Flag.

Class VulkanRenderer is derived from class DirectRenderer and class
DirectRenderer is updated in couple of patches. So override functions
having compilation issues.

Override functions removed, added and implemented in class
VulkanRenderer based on updated class DirectRenderer.

BUG=582558, 582564
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/93a32c6ea0a14da1e22455ade8e385f617671ba8
Cr-Commit-Position: refs/heads/master@{#426371}

[mayank.g1, 2016-10-18 06:55:18]

Description was changed from

==========
Fixed Build Errors in vulkan_renderer on Enabling Vulkan Flag

On Building with Vulkan Flag enabled build errors were comming.

All the build errors related to vulkan_renderer.cc and vulkan_renderer.h
are fixed in this patch.

BUG=582558, 582564
==========

to

==========
Fixed Build Errors in vulkan_renderer on Enabling Vulkan Flag

On Building with Vulkan Flag enabled build errors were comming.

All the build errors related to vulkan_renderer.cc and vulkan_renderer.h
are fixed in this patch.

BUG=582558, 582564
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[mayank.g1, 2016-10-18 06:56:48]

Description was changed from

==========
Fixed Build Errors in vulkan_renderer on Enabling Vulkan Flag

On Building with Vulkan Flag enabled build errors were comming.

All the build errors related to vulkan_renderer.cc and vulkan_renderer.h
are fixed in this patch.

BUG=582558, 582564
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
Fixed Build Errors in vulkan_renderer on Enabling Vulkan Flag

On Building with Vulkan Flag enabled build errors were comming.

All the build errors related to vulkan_renderer.cc and vulkan_renderer.h
are fixed in this patch.

BUG=582558, 582564
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[mayank.g1, 2016-10-18 06:56:48]

mayank.g1@samsung.com changed reviewers:
+ a.suchit@chromium.org, a.suchit@samsung.com

[a.suchit2, 2016-10-18 11:59:11]

IMO, below is better hedding for the commit :
Fixed compilation errors in vulkan_renderer.h with enable_vulkan Flag.

VulkanRenderer is derived from DirectRenderer and virtual functions
DiscardBackbuffer and EnsureBackbuffer are removed from DirectRenderer in
previous commit : https://codereview.chromium.org/2254543003

Removed these override functions from VulkanRenderer also and other compilation
errors.

https://codereview.chromium.org/2423333002/diff/1/cc/output/vulkan_renderer.h
File cc/output/vulkan_renderer.h (right):

https://codereview.chromium.org/2423333002/diff/1/cc/output/vulkan_renderer.h...
cc/output/vulkan_renderer.h:26: void SwapBuffers(CompositorFrameMetadata
metadata) override;
This override function declaration is changed in class DirectRenderer.
Please update.

[a.suchit2, 2016-10-19 04:21:16]

Update the patch description :
class VulkanRenderer is derived from class DirectRenderer and class
DirectRenderer is updated in couple of patches. So override functions having
compilation issues.

Override functions Removed, Added and implemented in class VulkanRenderer based
on updated DirectRenderer class.

[mayank.g1, 2016-10-19 05:12:49]

Description was changed from

==========
Fixed Build Errors in vulkan_renderer on Enabling Vulkan Flag

On Building with Vulkan Flag enabled build errors were comming.

All the build errors related to vulkan_renderer.cc and vulkan_renderer.h
are fixed in this patch.

BUG=582558, 582564
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
Fixed Build Errors in vulkan_renderer on Enabling Vulkan Flag.

class VulkanRenderer is derived from class DirectRenderer
and class DirectRenderer is updated in couple of patches.
So override functions having compilation issues.

Override functions Removed, Added and implemented in class
VulkanRenderer based on updated DirectRenderer class.

BUG=582558, 582564

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[mayank.g1, 2016-10-19 05:13:58]

Description was changed from

==========
Fixed Build Errors in vulkan_renderer on Enabling Vulkan Flag.

class VulkanRenderer is derived from class DirectRenderer
and class DirectRenderer is updated in couple of patches.
So override functions having compilation issues.

Override functions Removed, Added and implemented in class
VulkanRenderer based on updated DirectRenderer class.

BUG=582558, 582564

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
Fixed compilation errors in vulkan_renderer.h with enable_vulkan Flag.

class VulkanRenderer is derived from class DirectRenderer
and class DirectRenderer is updated in couple of patches.
So override functions having compilation issues.

Override functions Removed, Added and implemented in class
VulkanRenderer based on updated DirectRenderer class.

BUG=582558, 582564

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[a.suchit2, 2016-10-19 05:23:33]

a.suchit@chromium.org changed reviewers:
+ danakj@chromium.org, enne@chromium.org, piman@chromium.org

[a.suchit2, 2016-10-19 05:23:33]

Peer review looks good to me.

[a.suchit2, 2016-10-19 05:26:34]

Description was changed from

==========
Fixed compilation errors in vulkan_renderer.h with enable_vulkan Flag.

class VulkanRenderer is derived from class DirectRenderer
and class DirectRenderer is updated in couple of patches.
So override functions having compilation issues.

Override functions Removed, Added and implemented in class
VulkanRenderer based on updated DirectRenderer class.

BUG=582558, 582564

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
Fixed compilation errors in vulkan_renderer.h with enable_vulkan Flag.

Class VulkanRenderer is derived from class DirectRenderer and class
DirectRenderer is updated in couple of patches. So override functions
having compilation issues.

Override functions removed, added and implemented in class
VulkanRenderer based on updated class DirectRenderer.

BUG=582558, 582564

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[piman, 2016-10-19 21:20:54]

LGTM because the code is correct, but TBH, we will likely never use this - we're
investigating making a SkiaRenderer that could use Skia's Vulkan backend
instead.

[a.suchit2, 2016-10-20 00:49:07]

The CQ bit was checked by a.suchit@chromium.org

[commit-bot: I haz the power, 2016-10-20 00:49:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-20 01:52:02]

Description was changed from

==========
Fixed compilation errors in vulkan_renderer.h with enable_vulkan Flag.

Class VulkanRenderer is derived from class DirectRenderer and class
DirectRenderer is updated in couple of patches. So override functions
having compilation issues.

Override functions removed, added and implemented in class
VulkanRenderer based on updated class DirectRenderer.

BUG=582558, 582564

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
Fixed compilation errors in vulkan_renderer.h with enable_vulkan Flag.

Class VulkanRenderer is derived from class DirectRenderer and class
DirectRenderer is updated in couple of patches. So override functions
having compilation issues.

Override functions removed, added and implemented in class
VulkanRenderer based on updated class DirectRenderer.

BUG=582558, 582564

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[commit-bot: I haz the power, 2016-10-20 01:52:03]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-21 13:14:25]

Description was changed from

==========
Fixed compilation errors in vulkan_renderer.h with enable_vulkan Flag.

Class VulkanRenderer is derived from class DirectRenderer and class
DirectRenderer is updated in couple of patches. So override functions
having compilation issues.

Override functions removed, added and implemented in class
VulkanRenderer based on updated class DirectRenderer.

BUG=582558, 582564

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
Fixed compilation errors in vulkan_renderer.h with enable_vulkan Flag.

Class VulkanRenderer is derived from class DirectRenderer and class
DirectRenderer is updated in couple of patches. So override functions
having compilation issues.

Override functions removed, added and implemented in class
VulkanRenderer based on updated class DirectRenderer.

BUG=582558, 582564

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/93a32c6ea0a14da1e22455ade8e385f617671ba8
Cr-Commit-Position: refs/heads/master@{#426371}
==========

[commit-bot: I haz the power, 2016-10-21 13:14:26]

Patchset 2 (id:??) landed as
https://crrev.com/93a32c6ea0a14da1e22455ade8e385f617671ba8
Cr-Commit-Position: refs/heads/master@{#426371}