Emulate compiling a source file in the context of an existing library. Add --debugger-compile flag …

pkg/dev_compiler/lib/src/compiler/compiler.dart

Index: pkg/dev_compiler/lib/src/compiler/compiler.dart
diff --git a/pkg/dev_compiler/lib/src/compiler/compiler.dart b/pkg/dev_compiler/lib/src/compiler/compiler.dart
index e789bca3278c080ed1642d2fb992e9810afb8947..ef71e95b855229f05e33983029f7460b13b4710c 100644
--- a/pkg/dev_compiler/lib/src/compiler/compiler.dart
+++ b/pkg/dev_compiler/lib/src/compiler/compiler.dart
@@ -16,6 +16,7 @@ import 'package:analyzer/src/generated/source_io.dart'
     show Source, SourceKind, UriResolver;
 import 'package:analyzer/src/summary/package_bundle_reader.dart'
     show InSummarySource, InputPackagesResultProvider, SummaryDataStore;
+import 'package:analyzer/src/error/codes.dart' show StaticTypeWarningCode;
 import 'package:args/args.dart' show ArgParser, ArgResults;
 import 'package:args/src/usage_exception.dart' show UsageException;
 import 'package:func/func.dart' show Func1;
@@ -159,6 +160,7 @@ class ModuleCompiler {
     }
 
     sortErrors(context, errors);
+
     var messages = <String>[];
     for (var e in errors) {
       var m = formatError(context, e);
@@ -166,10 +168,22 @@ class ModuleCompiler {
     }
 
     if (!options.unsafeForceCompile &&
-        errors.any((e) => errorSeverity(context, e) == ErrorSeverity.ERROR)) {
+        errors.any(options.replCompile
+            ? (e) {

[Jennifer Messerly, 2016/10/18 18:46:01]

style: could we pull this out into its own function?

if (!options.unsafeForceCompile && errors.any(_isFatalError)) {
  ...
}


bool _isFatalError(AnalysisError e) {
  if (errorSeverity(context, e) != ErrorSeverity.ERROR) return false;

 // These errors are not fatal in the REPL compile mode [...]
 // [...]
 return !options.replCompile ||
      e.errorCode != StaticTypeWarningCode.UNDEFINED_GETTER &&
      e.errorCode != StaticTypeWarningCode.UNDEFINED_SETTER &&
      e.errorCode != StaticTypeWarningCode.UNDEFINED_METHOD;
}

+                // These errors are not fatal in the REPL compile mode as we
+                // allow access to private members across library boundaries
+                // and those accesses will show up as undefined members unless
+                // additional analyzer changes are made to support them.
+                // TODO(jacobr): consider checking that the identifier name
+                // referenced by the error is private.
+                return errorSeverity(context, e) == ErrorSeverity.ERROR &&
+                    e.errorCode != StaticTypeWarningCode.UNDEFINED_GETTER &&
+                    e.errorCode != StaticTypeWarningCode.UNDEFINED_SETTER &&
+                    e.errorCode != StaticTypeWarningCode.UNDEFINED_METHOD;
+              }
+            : (e) => errorSeverity(context, e) == ErrorSeverity.ERROR)) {
       return new JSModuleFile.invalid(unit.name, messages, options);
     }
-
     var codeGenerator =
         new CodeGenerator(context, summaryData, options, _extensionTypes);
     return codeGenerator.compile(unit, trees, messages);
@@ -204,6 +218,10 @@ class CompilerOptions {
   /// Whether to force compilation of code with static errors.
   final bool unsafeForceCompile;
 
+  /// Whether to compile code in a more permissive REPL mode allowing access
+  /// to private members across library boundaries.
+  final bool replCompile;
+
   /// Whether to emit Closure Compiler-friendly code.
   final bool closure;
 
@@ -248,6 +266,7 @@ class CompilerOptions {
       this.summarizeApi: true,
       this.summaryExtension: 'sum',
       this.unsafeForceCompile: false,
+      this.replCompile: false,
       this.emitMetadata: false,
       this.closure: false,
       this.destructureNamedParams: false,
@@ -265,6 +284,7 @@ class CompilerOptions {
         summarizeApi = args['summarize'],
         summaryExtension = args['summary-extension'],
         unsafeForceCompile = args['unsafe-force-compile'],
+        replCompile = args['repl-compile'],
         emitMetadata = args['emit-metadata'],
         closure = args['closure-experimental'],
         destructureNamedParams = args['destructure-named-params'],
@@ -303,6 +323,11 @@ class CompilerOptions {
               'This has undefined behavior!',
           defaultsTo: false,
           hide: true)
+      ..addFlag('repl-compile',
+          help: 'Compile code more permissively when in REPL mode allowing '
+              'access to private members across library boundaries.',
+          defaultsTo: false,
+          hide: true)
       ..addFlag('hoist-instance-creation',
           help: 'Hoist the class type from generic instance creations',
           defaultsTo: true,