Emulate compiling a source file in the context of an existing library. Add --debugger-compile flag …

pkg/dev_compiler/lib/src/compiler/compiler.dart

 // Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import 'dart:collection' show HashSet, Queue;
 import 'dart:convert' show BASE64, JSON, UTF8;
 import 'dart:io' show File;
 import 'package:analyzer/dart/element/element.dart' show LibraryElement;
 import 'package:analyzer/analyzer.dart'
     show AnalysisError, CompilationUnit, ErrorSeverity;
 import 'package:analyzer/file_system/file_system.dart' show ResourceProvider;
 import 'package:analyzer/src/generated/engine.dart'
     show AnalysisContext, AnalysisEngine;
 import 'package:analyzer/src/generated/source.dart' show DartUriResolver;
 import 'package:analyzer/src/generated/source_io.dart'
     show Source, SourceKind, UriResolver;
 import 'package:analyzer/src/summary/package_bundle_reader.dart'
     show InSummarySource, InputPackagesResultProvider, SummaryDataStore;
+import 'package:analyzer/src/error/codes.dart' show StaticTypeWarningCode;
 import 'package:args/args.dart' show ArgParser, ArgResults;
 import 'package:args/src/usage_exception.dart' show UsageException;
 import 'package:func/func.dart' show Func1;
 import 'package:path/path.dart' as path;
 import 'package:source_maps/source_maps.dart';
 
 import '../analyzer/context.dart'
     show
         AnalyzerOptions,
         createAnalysisContext,
@@ skipping 123 matching lines @@
       trees.add(tree);
       errors.addAll(context.computeErrors(library.source));
 
       for (var part in library.parts) {
         trees.add(context.resolveCompilationUnit(part.source, library));
         errors.addAll(context.computeErrors(part.source));
       }
     }
 
     sortErrors(context, errors);
+
     var messages = <String>[];
     for (var e in errors) {
       var m = formatError(context, e);
       if (m != null) messages.add(m);
     }
 
     if (!options.unsafeForceCompile &&
-        errors.any((e) => errorSeverity(context, e) == ErrorSeverity.ERROR)) {
+        errors.any(options.replCompile
+            ? (e) {

[Jennifer Messerly, 2016/10/18 18:46:01]

style: could we pull this out into its own function?

if (!options.unsafeForceCompile && errors.any(_isFatalError)) {
  ...
}


bool _isFatalError(AnalysisError e) {
  if (errorSeverity(context, e) != ErrorSeverity.ERROR) return false;

 // These errors are not fatal in the REPL compile mode [...]
 // [...]
 return !options.replCompile ||
      e.errorCode != StaticTypeWarningCode.UNDEFINED_GETTER &&
      e.errorCode != StaticTypeWarningCode.UNDEFINED_SETTER &&
      e.errorCode != StaticTypeWarningCode.UNDEFINED_METHOD;
}

+                // These errors are not fatal in the REPL compile mode as we
+                // allow access to private members across library boundaries
+                // and those accesses will show up as undefined members unless
+                // additional analyzer changes are made to support them.
+                // TODO(jacobr): consider checking that the identifier name
+                // referenced by the error is private.
+                return errorSeverity(context, e) == ErrorSeverity.ERROR &&
+                    e.errorCode != StaticTypeWarningCode.UNDEFINED_GETTER &&
+                    e.errorCode != StaticTypeWarningCode.UNDEFINED_SETTER &&
+                    e.errorCode != StaticTypeWarningCode.UNDEFINED_METHOD;
+              }
+            : (e) => errorSeverity(context, e) == ErrorSeverity.ERROR)) {
       return new JSModuleFile.invalid(unit.name, messages, options);
     }
-
     var codeGenerator =
         new CodeGenerator(context, summaryData, options, _extensionTypes);
     return codeGenerator.compile(unit, trees, messages);
   }
 }
 
 class CompilerOptions {
   /// Whether to emit the source mapping file.
   ///
   /// This supports debugging the original source code instead of the generated
@@ skipping 14 matching lines @@
 
   /// The file extension for summaries.
   final String summaryExtension;
 
   /// Whether to preserve metdata only accessible via mirrors
   final bool emitMetadata;
 
   /// Whether to force compilation of code with static errors.
   final bool unsafeForceCompile;
 
+  /// Whether to compile code in a more permissive REPL mode allowing access
+  /// to private members across library boundaries.
+  final bool replCompile;
+
   /// Whether to emit Closure Compiler-friendly code.
   final bool closure;
 
   /// Hoist the types at instance creation sites
   final bool hoistInstanceCreation;
 
   /// Hoist types from class signatures
   final bool hoistSignatureTypes;
 
   /// Name types in type tests
@@ skipping 24 matching lines @@
   /// source maps.
   final Map<String, String> bazelMapping;
 
   const CompilerOptions(
       {this.sourceMap: true,
       this.sourceMapComment: true,
       this.inlineSourceMap: false,
       this.summarizeApi: true,
       this.summaryExtension: 'sum',
       this.unsafeForceCompile: false,
+      this.replCompile: false,
       this.emitMetadata: false,
       this.closure: false,
       this.destructureNamedParams: false,
       this.hoistInstanceCreation: true,
       this.hoistSignatureTypes: false,
       this.nameTypeTests: true,
       this.hoistTypeTests: true,
       this.useAngular2Whitelist: false,
       this.bazelMapping: const {}});
 
   CompilerOptions.fromArguments(ArgResults args)
       : sourceMap = args['source-map'],
         sourceMapComment = args['source-map-comment'],
         inlineSourceMap = args['inline-source-map'],
         summarizeApi = args['summarize'],
         summaryExtension = args['summary-extension'],
         unsafeForceCompile = args['unsafe-force-compile'],
+        replCompile = args['repl-compile'],
         emitMetadata = args['emit-metadata'],
         closure = args['closure-experimental'],
         destructureNamedParams = args['destructure-named-params'],
         hoistInstanceCreation = args['hoist-instance-creation'],
         hoistSignatureTypes = args['hoist-signature-types'],
         nameTypeTests = args['name-type-tests'],
         hoistTypeTests = args['hoist-type-tests'],
         useAngular2Whitelist = args['unsafe-angular2-whitelist'],
         bazelMapping = _parseBazelMappings(args['bazel-mapping']);
 
@@ skipping 18 matching lines @@
       ..addFlag('closure-experimental',
           help: 'emit Closure Compiler-friendly code (experimental)',
           defaultsTo: false)
       ..addFlag('destructure-named-params',
           help: 'Destructure named parameters', defaultsTo: false, hide: true)
       ..addFlag('unsafe-force-compile',
           help: 'Compile code even if it has errors. ಠ_ಠ\n'
               'This has undefined behavior!',
           defaultsTo: false,
           hide: true)
+      ..addFlag('repl-compile',
+          help: 'Compile code more permissively when in REPL mode allowing '
+              'access to private members across library boundaries.',
+          defaultsTo: false,
+          hide: true)
       ..addFlag('hoist-instance-creation',
           help: 'Hoist the class type from generic instance creations',
           defaultsTo: true,
           hide: true)
       ..addFlag('hoist-signature-types',
           help: 'Hoist types from class signatures',
           defaultsTo: false,
           hide: true)
       ..addFlag('name-type-tests',
           help: 'Name types used in type tests', defaultsTo: true, hide: true)
@@ skipping 189 matching lines @@
     // Fall back to a relative path.
     return path.toUri(path.relative(path.fromUri(uri), from: dir)).toString();
   }
 
   for (int i = 0; i < list.length; i++) {
     list[i] = transformUri(list[i]);
   }
   map['file'] = transformUri(map['file']);
   return map;
 }