Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Issue 2423243002: Fix regression where navigating to debug URLs didn't update the omnibox. (Closed)

Created:
4 years, 2 months ago by jam
Modified:
4 years, 2 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2883
Project:
chromium
Visibility:
Public.

Description

Fix regression where navigating to debug URLs didn't update the omnibox. The regression test also exposed that this was broken with PlzNavigate, so fix that as well by not discarding pending entries when encountering navigation errors for debug URLs. This regressed in r422302. BUG=655109 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2415173002 Cr-Commit-Position: refs/heads/master@{#425415} (cherry picked from commit 0b18f8385af6097264889f6e368bbd3b31c11b09) Committed: https://chromium.googlesource.com/chromium/src/+/c3b34968218a7f6223dd06069a267ad0a04a8504

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -8 lines) Patch
M chrome/browser/crash_recovery_browsertest.cc View 3 chunks +9 lines, -4 lines 0 comments Download
M content/browser/frame_host/navigator_impl.cc View 2 chunks +9 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
jam
4 years, 2 months ago (2016-10-17 19:40:44 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c3b34968218a7f6223dd06069a267ad0a04a8504.

Powered by Google App Engine
This is Rietveld 408576698