Fix regression where navigating to debug URLs didn't update the omnibox.

Fix regression where navigating to debug URLs didn't update the omnibox.

The regression test also exposed that this was broken with PlzNavigate, so fix that as well by not discarding pending entries when encountering navigation errors for debug URLs.

This regressed in r422302.

BUG=655109
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/0b18f8385af6097264889f6e368bbd3b31c11b09
Cr-Commit-Position: refs/heads/master@{#425415}

[jam, 2016-10-13 17:41:33]

Description was changed from

==========
mgit c# Enter a description of the change.
Fix regression where navigating to debug URLs didn't update the omnibox.

This regressed in r422302.

BUG=655109
==========

to

==========
mgit c# Enter a description of the change.
Fix regression where navigating to debug URLs didn't update the omnibox.

This regressed in r422302.

BUG=655109
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[jam, 2016-10-13 17:45:20]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-13 17:45:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jam, 2016-10-13 17:46:11]

Description was changed from

==========
mgit c# Enter a description of the change.
Fix regression where navigating to debug URLs didn't update the omnibox.

This regressed in r422302.

BUG=655109
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Fix regression where navigating to debug URLs didn't update the omnibox.

This regressed in r422302.

BUG=655109
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[jam, 2016-10-13 17:46:11]

jam@chromium.org changed reviewers:
+ scottmg@chromium.org

[commit-bot: I haz the power, 2016-10-13 18:51:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-13 18:51:47]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[jam, 2016-10-13 20:04:21]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-13 20:04:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jam, 2016-10-13 20:06:07]

jam@chromium.org changed reviewers:
+ creis@chromium.org
- scottmg@chromium.org

[jam, 2016-10-13 20:27:52]

https://codereview.chromium.org/2415173002/diff/1/content/browser/frame_host/...
File content/browser/frame_host/navigator_impl.cc (right):

https://codereview.chromium.org/2415173002/diff/1/content/browser/frame_host/...
content/browser/frame_host/navigator_impl.cc:426:
dest_url.SchemeIs(url::kJavaScriptScheme)) {
I made this change while changing another line below to use IsRendererDebugURL
for consistency and depended on tests to find any possible side effects. looks
like this shouldn't have been changed.

[jam, 2016-10-13 20:34:24]

Description was changed from

==========
Fix regression where navigating to debug URLs didn't update the omnibox.

This regressed in r422302.

BUG=655109
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Fix regression where navigating to debug URLs didn't update the omnibox.

The regression test also exposed that this was broken with PlzNavigate, so fix
that as well by not discarding pending entries when encountering navigation
errors for debug URLs.

This regressed in r422302.

BUG=655109
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[commit-bot: I haz the power, 2016-10-13 20:57:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-13 20:57:19]

Dry run: This issue passed the CQ dry run.

[jam, 2016-10-14 17:24:47]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-14 17:25:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Charlie Reis, 2016-10-14 18:28:52]

Ok, LGTM.  (I'm conflicted about the behavior, but I can understand the argument
for it.  More detailed thoughts at https://crbug.com/541032#c2.)

[commit-bot: I haz the power, 2016-10-14 18:41:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-14 18:41:38]

Dry run: This issue passed the CQ dry run.

[jam, 2016-10-14 19:01:10]

The CQ bit was checked by jam@chromium.org

[jam, 2016-10-14 19:02:17]

On 2016/10/14 18:28:52, Charlie Reis (Away till 10-14) wrote:
> Ok, LGTM.  (I'm conflicted about the behavior, but I can understand the
argument
> for it.  More detailed thoughts at https://crbug.com/541032#c2.)

I agree that it's questionable what the UI should be. I just thought that my
change accidentally caused this change of behavior, so if we want to change it
that should be discussed separately.

[commit-bot: I haz the power, 2016-10-14 19:02:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-14 19:08:33]

Description was changed from

==========
Fix regression where navigating to debug URLs didn't update the omnibox.

The regression test also exposed that this was broken with PlzNavigate, so fix
that as well by not discarding pending entries when encountering navigation
errors for debug URLs.

This regressed in r422302.

BUG=655109
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Fix regression where navigating to debug URLs didn't update the omnibox.

The regression test also exposed that this was broken with PlzNavigate, so fix
that as well by not discarding pending entries when encountering navigation
errors for debug URLs.

This regressed in r422302.

BUG=655109
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[commit-bot: I haz the power, 2016-10-14 19:08:34]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-14 19:11:50]

Description was changed from

==========
Fix regression where navigating to debug URLs didn't update the omnibox.

The regression test also exposed that this was broken with PlzNavigate, so fix
that as well by not discarding pending entries when encountering navigation
errors for debug URLs.

This regressed in r422302.

BUG=655109
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Fix regression where navigating to debug URLs didn't update the omnibox.

The regression test also exposed that this was broken with PlzNavigate, so fix
that as well by not discarding pending entries when encountering navigation
errors for debug URLs.

This regressed in r422302.

BUG=655109
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/0b18f8385af6097264889f6e368bbd3b31c11b09
Cr-Commit-Position: refs/heads/master@{#425415}
==========

[commit-bot: I haz the power, 2016-10-14 19:11:51]

Patchset 3 (id:??) landed as
https://crrev.com/0b18f8385af6097264889f6e368bbd3b31c11b09
Cr-Commit-Position: refs/heads/master@{#425415}