Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(598)

Issue 2423193002: [Mac] Fix Animation Issue With the Security State Decoration (Closed)

Created:
4 years, 2 months ago by spqchan
Modified:
4 years, 2 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2883
Project:
chromium
Visibility:
Public.

Description

[Mac] Fix Animation Issue With the Security State Decoration Reset the decoration's animation if it's hidden BUG=653602 Review-Url: https://codereview.chromium.org/2408253002 Cr-Commit-Position: refs/heads/master@{#425378} (cherry picked from commit 8ae400d406c3a7e3fb08b47256d4d54fb60fc555) Committed: https://chromium.googlesource.com/chromium/src/+/a9f993aeb65b6c5513afe9e8661a88b063b66707

Patch Set 1 #

Patch Set 2 : Change default value #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -2 lines) Patch
M chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm View 1 3 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/security_state_bubble_decoration.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/security_state_bubble_decoration.mm View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
spqchan
4 years, 2 months ago (2016-10-17 19:33:10 UTC) #2
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
a9f993aeb65b6c5513afe9e8661a88b063b66707.

Powered by Google App Engine
This is Rietveld 408576698