Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Issue 2408253002: [Mac] Fix Animation Issue With the Security State Decoration (Closed)

Created:
4 years, 2 months ago by spqchan
Modified:
4 years, 2 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac] Fix Animation Issue With the Security State Decoration Reset the decoration's animation if it's hidden BUG=653602 Committed: https://crrev.com/8ae400d406c3a7e3fb08b47256d4d54fb60fc555 Cr-Commit-Position: refs/heads/master@{#425378}

Patch Set 1 #

Patch Set 2 : Fixed something with the tab #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -1 line) Patch
M chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm View 1 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/location_bar/security_state_bubble_decoration.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/security_state_bubble_decoration.mm View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
spqchan
PTAL
4 years, 2 months ago (2016-10-14 00:10:56 UTC) #2
Robert Sesek
LGTM
4 years, 2 months ago (2016-10-14 14:41:53 UTC) #3
spqchan
On 2016/10/14 14:41:53, Robert Sesek wrote: > LGTM thanks!
4 years, 2 months ago (2016-10-14 17:15:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2408253002/20001
4 years, 2 months ago (2016-10-14 17:16:21 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-14 17:40:28 UTC) #7
commit-bot: I haz the power
4 years, 2 months ago (2016-10-14 17:42:43 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8ae400d406c3a7e3fb08b47256d4d54fb60fc555
Cr-Commit-Position: refs/heads/master@{#425378}

Powered by Google App Engine
This is Rietveld 408576698