Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(460)

Issue 2423153004: Revert of [Offline pages] Ensuring verbose Offline status does not show next to the security padlock (Closed)

Created:
4 years, 2 months ago by fgorski
Modified:
4 years, 2 months ago
Reviewers:
Ted C
CC:
chromium-reviews, dewittj+watch_chromium.org, fgorski+watch_chromium.org, romax+watch_chromium.org, petewil+watch_chromium.org, chili+watch_chromium.org, agrieve+watch_chromium.org, dimich+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Offline pages] Ensuring verbose Offline status does not show next to the security padlock (patchset #2 id:40001 of https://codereview.chromium.org/2412273002/ ) Reason for revert: Reverting per offline discussion with tedchoc@ as this patch introduced bug 655923 Original issue's description: > [Offline pages] Ensuring verbose Offline status does not show next to the security padlock > > * Ensuring the verbose status is updated when the padlock animation ends > * Ensuring the URL is properly emphasized when that happens as well > > BUG=648129 > > Committed: https://crrev.com/083092ef6ec00129ebf7d755b323a1cb90cdb659 > Cr-Commit-Position: refs/heads/master@{#425140} TBR=tedchoc@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=648129 Committed: https://crrev.com/6eb43a4602315a47eb11f12ac6a302534f040070 Cr-Commit-Position: refs/heads/master@{#425836}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -12 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java View 3 chunks +2 lines, -12 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
fgorski
Created Revert of [Offline pages] Ensuring verbose Offline status does not show next to the ...
4 years, 2 months ago (2016-10-17 23:08:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2423153004/1
4 years, 2 months ago (2016-10-17 23:08:40 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-18 00:41:57 UTC) #4
commit-bot: I haz the power
4 years, 2 months ago (2016-10-18 00:45:00 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6eb43a4602315a47eb11f12ac6a302534f040070
Cr-Commit-Position: refs/heads/master@{#425836}

Powered by Google App Engine
This is Rietveld 408576698