Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1187)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java

Issue 2423153004: Revert of [Offline pages] Ensuring verbose Offline status does not show next to the security padlock (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java b/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java
index c5a8eecc2dd27bd975f33b04b9a5ab02e0671f98..0316586707af28178ece61d8c59e9e304409d2ce 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java
@@ -674,12 +674,6 @@
} else if (animation == mNavigationIconShowAnimator) {
mSecurityButton.setVisibility(INVISIBLE);
}
- // This is done specifically not to show offline page verbose status with the
- // icon. It should be properly solved, when omnibox verbose status animation is
- // implemented. See: http://crbug.com/648129
- updateVerboseStatusVisibility();
- // URL cleanup to not show not emphasized URL next to padlock.
- setUrlToPageUrl();
}
@Override
@@ -689,8 +683,6 @@
} else if (animation == mNavigationIconShowAnimator) {
mNavigationButton.setVisibility(VISIBLE);
}
- // As above. See: http://crbug.com/648129
- updateVerboseStatusVisibility();
}
};
@@ -1397,10 +1389,8 @@
* omnibox.
*/
private void updateVerboseStatusVisibility() {
- boolean verboseStatusVisible = !mUrlHasFocus
- && mNavigationButtonType == NavigationButtonType.OFFLINE
- && mNavigationButton.getVisibility() == VISIBLE
- && mSecurityButton.getVisibility() == INVISIBLE;
+ boolean verboseStatusVisible =
+ mNavigationButtonType == NavigationButtonType.OFFLINE && !mUrlHasFocus;
int verboseStatusVisibility = verboseStatusVisible ? VISIBLE : GONE;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698